From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
hch@infradead.org
Subject: Re: [PATCH] fs: Make sure data stored into inode is properly seen before unlocking new inode
Date: Sat, 12 Sep 2009 16:06:25 +0100 [thread overview]
Message-ID: <20090912150625.GF5858@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1252410063-26872-1-git-send-email-jack@suse.cz>
On Tue, Sep 08, 2009 at 01:41:03PM +0200, Jan Kara wrote:
> In theory it could happen that on one CPU we initialize a new inode but clearing
> of I_NEW | I_LOCK gets reordered before some of the initialization. Thus on
> another CPU we return not fully uptodate inode from iget_locked().
>
> This seems to fix a corruption issue on ext3 mounted over NFS.
Nice catch. ACK.
> Since Al doesn't seem to be online, does anybody else have opinion on this
> patch? I can merge it via my tree but I'd like to get a review from someone
> else.
I'm back, actually, and finally had almost crawled from under the pile
of mail in mbox. Will apply.
prev parent reply other threads:[~2009-09-12 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 11:41 [PATCH] fs: Make sure data stored into inode is properly seen before unlocking new inode Jan Kara
2009-09-08 18:42 ` Christoph Hellwig
2009-09-09 22:03 ` Andrew Morton
2009-09-10 9:07 ` Jan Kara
2009-09-12 15:06 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912150625.GF5858@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.