From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MmUcp-0005iV-Ii
	for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:34:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MmUck-0005hN-Rr
	for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:34:55 -0400
Received: from [199.232.76.173] (port=55903 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MmUck-0005hK-M9
	for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:34:50 -0400
Received: from mail.gmx.net ([213.165.64.20]:46186)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <Reimar.Doeffinger@gmx.de>) id 1MmUck-00070k-1U
	for qemu-devel@nongnu.org; Sat, 12 Sep 2009 11:34:50 -0400
Date: Sat, 12 Sep 2009 17:34:44 +0200
From: Reimar =?iso-8859-1?Q?D=F6ffinger?= <Reimar.Doeffinger@gmx.de>
Subject: Re: [Qemu-devel] Re: [PATCH] Unlike real hardware, vmport needs
	access to the CPU [...]
Message-ID: <20090912153444.GA8417@1und1.de>
References: <20090912141128.GA15236@1und1.de>
 <4AABB42C.3070103@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4AABB42C.3070103@web.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

On Sat, Sep 12, 2009 at 04:46:04PM +0200, Jan Kiszka wrote:
> =?UTF-8?q?Reimar=20D=C3=B6ffinger?= wrote:
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
> > ---
> >  hw/vmport.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/hw/vmport.c b/hw/vmport.c
> > index 884af3f..9a942ee 100644
> > --- a/hw/vmport.c
> > +++ b/hw/vmport.c
> > @@ -25,6 +25,7 @@
> >  #include "isa.h"
> >  #include "pc.h"
> >  #include "sysemu.h"
> > +#include "kvm.h"
> >  
> >  //#define VMPORT_DEBUG
> >  
> > @@ -58,6 +59,7 @@ static uint32_t vmport_ioport_read(void *opaque, uint32_t addr)
> >      unsigned char command;
> >      uint32_t eax;
> >  
> > +    cpu_synchronize_state(env);
> >      eax = env->regs[R_EAX];
> >      if (eax != VMPORT_MAGIC)
> >          return eax;
> 
> Ack (qemu-kvm carries a similar patch).

Now that I look at it... yes.
Except that it does not yet have cpu_synchronize_state and thus is broken for
vmport_ioport_write, the return value written to EAX is lost.

> But please grant your patches some proper titles.

Sorry, I am still figuring out how to write commit messages that git format-patch
handles in a good way (as well as the most sane way to use it in
general).