Re: pahole displays type incorrectly

[Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Em Sat, Sep 12, 2009 at 11:49:39AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Sep 12, 2009 at 10:24:05AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sat, Sep 12, 2009 at 03:41:56AM +0200, Jan Engelhardt escreveu:
> > > 
> > > On Thursday 2009-09-10 22:35, Arnaldo Carvalho de Melo wrote:
> > > >
> > > >Sorry for the delay, should be fixed by the latest commit, please give
> > > >it a try!
> > > >
> > > >http://git.kernel.org/?p=linux/kernel/git/acme/pahole.git;a=commitdiff;h=846927a3f87f730e0ae201b5f0b3b46212a7bb8e
> > > 
> > > Yes it does work. The testcase seems to be reducable to just the
> > > struct without a function, but still with a non-static definition
> > > (instance) of the struct. I.e. on the file level:
> > > 
> > > struct foo {
> > > 	const char *const z;
> > > };
> > > struct foo x;
> > 
> > Thanks for testing! I'll update the test case to reduce it.
> 
> While running regtest I noticed it is still buggy :-\ It works when you
> have a "const char *const x"  case, but reverses both "const char *x"
> and "char *const x", but now parents are visiting, time to go AFK :-)
> 
> If anybody feels like looking at the latest commits to see how it
> should't be done and comes with a patch, I'd appreciate 8-)

Should be ok now. See lest cset, with test cases for:

const char *x;
char *const x;
const char *const x;

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html