From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix 'acpi' command loading tables from disk
Date: Sun, 13 Sep 2009 02:27:54 +0200 [thread overview]
Message-ID: <20090913002754.GA21002@thorin> (raw)
In-Reply-To: <66be81dd0909100521p4b9c113ctd3b7e8827dc3fde7@mail.gmail.com>
On Thu, Sep 10, 2009 at 02:21:14PM +0200, xose wrote:
> The 'acpi' command currently fails to add ACPI tables loaded from
> disk. The files are read and parsed correctly, but the tables are
> never actually added to the tables list.
>
> The following patch fixes this bug:
>
>
> diff --git a/commands/acpi.c b/commands/acpi.c
> index d903d44..e7cb9e6 100644
> --- a/commands/acpi.c
> +++ b/commands/acpi.c
> @@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd,
> table->size = size;
> table->addr = buf;
> playground_size += table->size;
> +
> + table->next = acpi_tables;
> + acpi_tables = table;
> }
> }
According to Vladimir, this patch is fine. Please, could you provide a
ChangeLog entry? Then it can be committed.
Thanks
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-09-13 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 12:21 [PATCH] Fix 'acpi' command loading tables from disk xose
2009-09-13 0:27 ` Robert Millan [this message]
2009-09-13 1:22 ` xose
2009-09-14 15:39 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913002754.GA21002@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.