All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.linux-foundation.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Shaohua Li <shaohua.li@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: [RFC][PATCH 1/4] PCI PM: Add function for checking PME status of devices
Date: Sun, 13 Sep 2009 23:20:58 +0200	[thread overview]
Message-ID: <200909132320.58093.rjw@sisk.pl> (raw)
In-Reply-To: <200909132320.05077.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Add function pci_check_pme_status() that will check the PME status
bit of given device and clear it along with the PME enable bit.  It
will be necessary for PCI run-time power management.

Based on a patch from Shaohua Li <shaohua.li@intel.com>

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/pci/pci.c |   35 +++++++++++++++++++++++++++++++++++
 drivers/pci/pci.h |    1 +
 2 files changed, 36 insertions(+)

Index: linux-2.6/drivers/pci/pci.h
===================================================================
--- linux-2.6.orig/drivers/pci/pci.h
+++ linux-2.6/drivers/pci/pci.h
@@ -48,6 +48,7 @@ struct pci_platform_pm_ops {
 extern int pci_set_platform_pm(struct pci_platform_pm_ops *ops);
 extern void pci_update_current_state(struct pci_dev *dev, pci_power_t state);
 extern void pci_disable_enabled_device(struct pci_dev *dev);
+extern bool pci_check_pme_status(struct pci_dev *dev);
 extern void pci_pm_init(struct pci_dev *dev);
 extern void platform_pci_wakeup_init(struct pci_dev *dev);
 extern void pci_allocate_cap_save_buffers(struct pci_dev *dev);
Index: linux-2.6/drivers/pci/pci.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci.c
+++ linux-2.6/drivers/pci/pci.c
@@ -1161,6 +1161,41 @@ int pci_set_pcie_reset_state(struct pci_
 }
 
 /**
+ * pci_check_pme_status - Check if given device has generated PME.
+ * @dev: Device to check.
+ *
+ * Check the PME status of the device, clear PME status and PME enable.  Return
+ * 'true' if PME has been generated by the device (and hasn't been spurious) or
+ * 'false' otherwise.
+ */
+bool pci_check_pme_status(struct pci_dev *dev)
+{
+	int pmcsr_pos;
+	u16 pmcsr;
+	bool ret = false;
+
+	if (!dev->pm_cap)
+		return false;
+
+	pmcsr_pos = dev->pm_cap + PCI_PM_CTRL;
+	/* clear PME status and disable PME to avoid interrupt flood */
+	pci_read_config_word(dev, pmcsr_pos, &pmcsr);
+	if (!(pmcsr & PCI_PM_CTRL_PME_STATUS))
+		return false;
+
+	pmcsr |= PCI_PM_CTRL_PME_STATUS;
+	/* Ignore spurious PME or clear PME enable if it's not spurious. */
+	if (pmcsr & PCI_PM_CTRL_PME_ENABLE) {
+		pmcsr &= ~PCI_PM_CTRL_PME_ENABLE;
+		ret = true;
+	}
+
+	pci_write_config_word(dev, pmcsr_pos, pmcsr);
+
+	return ret;
+}
+
+/**
  * pci_pme_capable - check the capability of PCI device to generate PME#
  * @dev: PCI device to handle.
  * @state: PCI state from which device will issue PME#.

  parent reply	other threads:[~2009-09-13 21:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 21:20 [RFC][PATCH 0/4] PCI / ACPI PM: Run-time PM, PME handling and PCI bus type callbacks Rafael J. Wysocki
2009-09-13 21:20 ` [RFC][PATCH 1/4] PCI PM: Add function for checking PME status of devices Rafael J. Wysocki
2009-09-13 21:20 ` Rafael J. Wysocki [this message]
2009-09-13 22:15   ` Matthew Garrett
2009-09-13 22:15   ` Matthew Garrett
2009-09-13 21:22 ` [RFC][PATCH 2/4] PCI PM: PCIe PME root port service driver (rev. 3) Rafael J. Wysocki
2009-09-13 21:22 ` Rafael J. Wysocki
2009-09-13 21:24 ` [RFC][PATCH 3/4] PCI / ACPI PM: Platform support for PCI PME wake-up Rafael J. Wysocki
2009-09-13 21:24 ` Rafael J. Wysocki
2009-09-13 22:25   ` Matthew Garrett
2009-09-13 22:53     ` Rafael J. Wysocki
2009-09-13 22:53     ` Rafael J. Wysocki
2009-09-13 22:55       ` Matthew Garrett
2009-09-13 22:55       ` Matthew Garrett
2009-09-13 23:08         ` Rafael J. Wysocki
2009-09-13 23:08         ` Rafael J. Wysocki
2009-09-21  0:26         ` Rafael J. Wysocki
2009-09-21  0:26         ` Rafael J. Wysocki
2009-10-06 17:32           ` Jesse Barnes
2009-10-06 17:32             ` Jesse Barnes
2009-10-06 21:32             ` Rafael J. Wysocki
2009-10-06 21:32               ` Rafael J. Wysocki
2009-09-13 22:25   ` Matthew Garrett
2009-09-13 21:25 ` [RFC][PATCH 4/4] PCI PM: Run-time callbacks for PCI bus type Rafael J. Wysocki
2009-09-13 21:25 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2009-10-08 22:51 [RFC][PATCH 0/4] PCI run-time Power Management Rafael J. Wysocki
2009-10-08 22:52 ` [RFC][PATCH 1/4] PCI PM: Add function for checking PME status of devices Rafael J. Wysocki
2009-10-08 23:32   ` Bjorn Helgaas
2009-10-08 23:32     ` Bjorn Helgaas
2009-10-09 22:11     ` Rafael J. Wysocki
2009-10-09 22:11       ` Rafael J. Wysocki
2009-10-08 22:52 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909132320.58093.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.