From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Javier Herrero <jherrero@hvsistemas.es>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH v3] input/keyboard: new OpenCores Keyboard Controller driver
Date: Mon, 14 Sep 2009 10:49:50 -0700 [thread overview]
Message-ID: <200909141049.50705.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <1252950003-9451-1-git-send-email-vapier@gentoo.org>
Hi Mike,
On Monday 14 September 2009 10:40:03 am Mike Frysinger wrote:
> +
> +struct opencores_kbd {
> + struct input_dev *input;
> + struct resource *addr_res;
> + struct resource *irq_res;
> + unsigned short *keycode;
> +};
Why do we allocate keycode table separately form the main structure?
I think I still have some reservations with the notion that we can just
have exact "scancode" - KEY_* mapping and hardware producers will adjust
the hardware to follow the deriver but I guess it's OK...
--
Dmitry
next prev parent reply other threads:[~2009-09-14 17:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 2:17 [PATCH] input/keyboard: new OpenCores Keyboard Controller driver Mike Frysinger
2009-09-14 6:17 ` Andrey Panin
2009-09-14 7:04 ` [PATCH v2] " Mike Frysinger
2009-09-14 7:25 ` Joe Perches
2009-09-14 17:40 ` [PATCH v3] " Mike Frysinger
2009-09-14 17:49 ` Dmitry Torokhov [this message]
2009-09-14 18:02 ` Mike Frysinger
2009-09-14 18:02 ` Mike Frysinger
2009-09-14 18:18 ` Javier Herrero
2009-09-15 5:52 ` Dmitry Torokhov
2009-09-15 11:16 ` Mike Frysinger
2009-09-15 11:16 ` Mike Frysinger
2009-09-15 16:23 ` Dmitry Torokhov
2009-09-15 16:23 ` Dmitry Torokhov
2009-09-15 16:39 ` Mike Frysinger
2009-09-15 16:39 ` Mike Frysinger
2009-09-16 2:00 ` [PATCH v4] " Mike Frysinger
2009-09-16 3:45 ` Dmitry Torokhov
2009-09-16 3:57 ` Mike Frysinger
2009-09-16 3:57 ` Mike Frysinger
2009-09-16 4:10 ` [PATCH v5] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909141049.50705.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=cooloney@kernel.org \
--cc=jherrero@hvsistemas.es \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.