From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MnDeA-0000N7-50 for mharc-grub-devel@gnu.org; Mon, 14 Sep 2009 11:39:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnDe4-0000Lu-Cw for grub-devel@gnu.org; Mon, 14 Sep 2009 11:39:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnDdy-0000Kv-Kf for grub-devel@gnu.org; Mon, 14 Sep 2009 11:39:11 -0400 Received: from [199.232.76.173] (port=37316 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnDdw-0000KZ-Gf for grub-devel@gnu.org; Mon, 14 Sep 2009 11:39:04 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:45743 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MnDdw-0005hR-5u for grub-devel@gnu.org; Mon, 14 Sep 2009 11:39:04 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MnDdu-00087j-C4 for grub-devel@gnu.org; Mon, 14 Sep 2009 17:39:02 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MnDdt-0006dd-RK for grub-devel@gnu.org; Mon, 14 Sep 2009 17:39:01 +0200 Date: Mon, 14 Sep 2009 17:39:01 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090914153901.GD25403@thorin> References: <66be81dd0909100521p4b9c113ctd3b7e8827dc3fde7@mail.gmail.com> <20090913002754.GA21002@thorin> <66be81dd0909121822t23546ffas927851a214ced8a8@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <66be81dd0909121822t23546ffas927851a214ced8a8@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix 'acpi' command loading tables from disk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2009 15:39:14 -0000 On Sun, Sep 13, 2009 at 03:22:41AM +0200, xose wrote: > On Sun, Sep 13, 2009 at 2:27 AM, Robert Millan wrote: > > On Thu, Sep 10, 2009 at 02:21:14PM +0200, xose wrote: > >> The 'acpi' command currently fails to add ACPI tables loaded from > >> disk. The files are read and parsed correctly, but the tables are > >> never actually added to the tables list. > >> > >> The following patch fixes this bug: > >> > >> > >> diff --git a/commands/acpi.c b/commands/acpi.c > >> index d903d44..e7cb9e6 100644 > >> --- a/commands/acpi.c > >> +++ b/commands/acpi.c > >> @@ -681,6 +681,9 @@ grub_cmd_acpi (struct grub_extcmd *cmd, > >>         table->size = size; > >>         table->addr = buf; > >>         playground_size += table->size; > >> + > >> +       table->next = acpi_tables; > >> +       acpi_tables = table; > >>       } > >>      } > > > > According to Vladimir, this patch is fine.  Please, could you provide a > > ChangeLog entry?  Then it can be committed. > > Sure, I forgot it the first time, sorry about that. > > > 2009-09-13 José Martínez > > * commands/acpi.c (grub_cmd_acpi): Fix loading ACPI tables from file. I checked this in. Btw, in the future please include patches as plain text attachments. Thanks! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."