From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, lenb@kernel.org, mingo@elte.hu,
peterz@infradead.org, yanmin_zhang@linux.intel.com,
torvalds@linux-foundation.org, jens.axboe@oracle.com,
Tejun Heo <tj@kernel.org>, David Howells <dhowells@redhat.com>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Subject: Re: PATCH] cpuidle: A new variant of the menu governor to boost IO performance
Date: Mon, 14 Sep 2009 22:31:58 +0200 [thread overview]
Message-ID: <20090914223158.60ea33f8@infradead.org> (raw)
In-Reply-To: <20090914004301.105196cc.akpm@linux-foundation.org>
On Mon, 14 Sep 2009 00:43:01 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
>
> static DEFINE_PER_CPU(struct menu_device, menu_devices);
>
> in both menu.c and menu-tng.c.
>
> Despite the `static', the percpu changes in
>
> commit 7c756e6e19e71f0327760d8955f7077118ebb2b1
> Author: Tejun Heo <tj@kernel.org>
> AuthorDate: Wed Jun 24 15:13:50 2009 +0900
> Commit: Tejun Heo <tj@kernel.org>
> CommitDate: Wed Jun 24 15:13:50 2009 +0900
>
> percpu: implement optional weak percpu definitions
>
> are emitting global symbol derived from `menu_devices' and they clash.
>
>
> I'll rename menu_devices to fix that up, but we have a problem...
I would consider "static" not working a problem...
yes here it's easy to fix, but it's not nice if you can't make .c file
private..
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
prev parent reply other threads:[~2009-09-14 20:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 15:40 PATCH] cpuidle: A new variant of the menu governor to boost IO performance Arjan van de Ven
2009-09-11 16:37 ` Jens Axboe
2009-09-11 19:16 ` John Stoffel
2009-09-11 19:51 ` Arjan van de Ven
2009-09-14 3:30 ` Zhang, Yanmin
2009-09-11 22:03 ` Matthew Garrett
2009-09-12 3:26 ` Arjan van de Ven
2009-09-12 11:39 ` Matthew Garrett
2009-09-12 14:04 ` Arjan van de Ven
2009-09-13 23:30 ` Andrew Morton
2009-09-14 2:45 ` Arjan van de Ven
2009-09-14 7:43 ` Andrew Morton
2009-09-14 8:04 ` Tejun Heo
2009-09-14 8:15 ` Peter Zijlstra
2009-09-14 9:09 ` Tejun Heo
2009-09-14 20:31 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090914223158.60ea33f8@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jens.axboe@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.