From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] S3C64XX DMA: TC-IRQ implemented.
Date: Tue, 15 Sep 2009 11:13:55 +0100 [thread overview]
Message-ID: <20090915101355.GD22878@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1253008883-7624-1-git-send-email-jassi.brar@samsung.com>
On Tue, Sep 15, 2009 at 07:01:23PM +0900, Jassi wrote:
> + if (errstat & bit)
> + writel(bit, dmac->regs + PL080_ERR_CLEAR);
The old code would complain in the logs on error, which seems like a
reasonable approach if we've no better idea what to do - it at least
tells people something about what might be going on if things break.
> + chan = dmac->channels + offs;
> + if(chan->curr == NULL)
> + continue;
It's probably a good idea to run your patches through
scripts/checkpatch.pl before submitting them.
next prev parent reply other threads:[~2009-09-15 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 10:01 [PATCH 5/7] S3C64XX DMA: TC-IRQ implemented Jassi
2009-09-15 10:13 ` Mark Brown [this message]
2009-09-15 11:04 ` jassi brar
2009-09-16 0:23 ` Ben Dooks
2009-09-16 2:43 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915101355.GD22878@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.