From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] S3C64XX I2S: Return correct codec clock
Date: Tue, 15 Sep 2009 12:06:35 +0100 [thread overview]
Message-ID: <20090915110635.GI22878@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1253008960-10666-1-git-send-email-jassi.brar@samsung.com>
On Tue, Sep 15, 2009 at 07:02:40PM +0900, Jassi wrote:
> - return i2s->iis_cclk;
> + if(iismod & S3C64XX_IISMOD_IMS_SYSMUX)
> + return i2s->iis_cclk;
> + else
> + return i2s->iis_pclk;
There's three possible clocks here according to the datasheet - PCLK,
CLKAUDIO and I2SCLK - so this will still give the wrong clock some of
the time. Also, please use checkpatch.
Ideally we wouldn't have to export the clock at all, of course.
next prev parent reply other threads:[~2009-09-15 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 10:02 [PATCH 08/10] S3C64XX I2S: Return correct codec clock Jassi
2009-09-15 11:06 ` Mark Brown [this message]
2009-09-15 11:21 ` jassi brar
2009-09-15 11:56 ` Mark Brown
2009-09-16 5:16 ` jassi brar
2009-09-16 11:09 ` Mark Brown
2009-09-16 11:50 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915110635.GI22878@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.