From: npiggin@suse.de
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [patch 5/5] fs: fix bdi writeback use after free 2
Date: Wed, 16 Sep 2009 05:19:08 +1000 [thread overview]
Message-ID: <20090915192243.247202587@suse.de> (raw)
In-Reply-To: 20090915191903.290006007@suse.de
[-- Attachment #1: fs-bdiwb-rcu-fix-3.patch --]
[-- Type: text/plain, Size: 1165 bytes --]
work can be gone after wb_clear_pending, so load the sb from it first.
Signed-off-by: Nick Piggin <npiggin@suse.de>
---
fs/fs-writeback.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/fs/fs-writeback.c
===================================================================
--- linux-2.6.orig/fs/fs-writeback.c
+++ linux-2.6/fs/fs-writeback.c
@@ -783,6 +783,7 @@ long wb_do_writeback(struct bdi_writebac
while ((work = get_next_work_item(bdi, wb)) != NULL) {
enum writeback_sync_modes sync_mode;
+ struct super_block *sb;
nr_pages = work->nr_pages;
@@ -794,6 +795,8 @@ long wb_do_writeback(struct bdi_writebac
else
sync_mode = work->sync_mode;
+ sb = work->sb;
+
/*
* If this isn't a data integrity operation, just notify
* that we have seen this work and we are now starting it.
@@ -801,7 +804,7 @@ long wb_do_writeback(struct bdi_writebac
if (sync_mode == WB_SYNC_NONE)
wb_clear_pending(wb, work);
- wrote += wb_writeback(wb, nr_pages, work->sb, sync_mode, 0);
+ wrote += wb_writeback(wb, nr_pages, sb, sync_mode, 0);
/*
* This is a data integrity writeback, so only do the
next prev parent reply other threads:[~2009-09-15 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 19:19 [patch 0/5] bdi writeback fixes npiggin
2009-09-15 19:19 ` [patch 1/5] fs: make use of rcu helpers npiggin
2009-09-15 19:31 ` Jens Axboe
2009-09-15 19:19 ` [patch 2/5] fs: improve scalability of bdi writeback work queues npiggin
2009-09-15 19:31 ` Jens Axboe
2009-09-15 19:19 ` [patch 3/5] fs: fix bdi writeback use after free 1 npiggin
2009-09-15 19:32 ` Jens Axboe
2009-09-15 19:19 ` [patch 4/5] fs: fix possible bdi writeback refcounting problem npiggin
2009-09-15 19:30 ` Jens Axboe
2009-09-15 19:19 ` npiggin [this message]
2009-09-15 19:29 ` [patch 5/5] fs: fix bdi writeback use after free 2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915192243.247202587@suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.