From: Borislav Petkov <borislav.petkov@amd.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] edac: need to export cpu_llc_id
Date: Wed, 16 Sep 2009 06:41:51 +0200 [thread overview]
Message-ID: <20090916044151.GB5767@aftab> (raw)
In-Reply-To: <20090916093935.6bc2c91f.sfr@canb.auug.org.au>
Hi Stephen,
On Wed, Sep 16, 2009 at 09:39:35AM +1000, Stephen Rothwell wrote:
> Today's linux-next build (x86_64 allmodconfig) failed like this:
>
> ERROR: "per_cpu__cpu_llc_id" [drivers/edac/edac_core.ko] undefined!
>
> Caused by commit b69b29de65fe4078b125acc9dea34be82f7c362c ("EDAC, AMD:
> carve out MCi_STATUS decoding").
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/x86/kernel/smpboot.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a25eeec..04c74b4 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -100,6 +100,7 @@ EXPORT_SYMBOL(smp_num_siblings);
>
> /* Last level cache ID of each logical CPU */
> DEFINE_PER_CPU(u16, cpu_llc_id) = BAD_APICID;
> +EXPORT_PER_CPU_SYMBOL(cpu_llc_id);
>
> /* representing HT siblings of each logical CPU */
> DEFINE_PER_CPU(cpumask_var_t, cpu_sibling_map);
> --
> 1.6.3.3
proper fix is at http://marc.info/?l=linux-kernel&m=125302459621925
we still have to figure out who's gonna pick it up. Ingo?
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2009-09-16 4:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 23:39 [PATCH] edac: need to export cpu_llc_id Stephen Rothwell
2009-09-16 4:41 ` Borislav Petkov [this message]
2009-09-16 4:51 ` H. Peter Anvin
2009-09-16 4:58 ` Borislav Petkov
2009-09-16 15:49 ` Stephen Rothwell
2009-09-16 16:04 ` Borislav Petkov
2009-09-17 0:35 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916044151.GB5767@aftab \
--to=borislav.petkov@amd.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.