All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] S3C I2S: lrsync function made to work with IRQs disabled.
Date: Wed, 16 Sep 2009 11:26:58 +0100	[thread overview]
Message-ID: <20090916102657.GC3589@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1b68c6790909151803t74698905o2712db68ce03ea01@mail.gmail.com>

On Wed, Sep 16, 2009 at 10:03:41AM +0900, jassi brar wrote:
> On Wed, Sep 16, 2009 at 9:14 AM, Ben Dooks <ben-linux@fluff.org> wrote:

> > I don't think cpu_relax() gives a defined 'timeout' length, thus this
> > loop is of a very indeterminate length of timeout.

> Ofcourse the total delay is non-deterministic. Besides, there is no
> hard limit on the amount of time we want to wait on lrsync. And this
> non-deterministic delay comes into picture only when the I2S is
> broken. It is second best option to simply hanging.
> Total wait period is _atleast_ what we want, as is mentioned in the changelog.

The length of time you should need to wait for a LRCLK transition is
given by the sample rate - even 1ms is a very generous timeout for 8kHz,
which is the lowest sample rate you'd really expect to see.  The actual
value isn't terribly important since we should never hit it when things
aren't broken.

      reply	other threads:[~2009-09-16 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 10:02 [PATCH 05/10] S3C I2S: lrsync function made to work with IRQs disabled Jassi
2009-09-15 12:21 ` Mark Brown
2009-09-16  0:14 ` Ben Dooks
2009-09-16  1:03   ` jassi brar
2009-09-16 10:26     ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090916102657.GC3589@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.