From: Theodore Tso <tytso@mit.edu>
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: linux-ext4@vger.kernel.org, Peng Tao <bergwolf@gmail.com>
Subject: Re: [PATCH 4/4]ext4: Fix different block exchange issue in EXT4_IOC_MOVE_EXT
Date: Wed, 16 Sep 2009 14:20:57 -0400 [thread overview]
Message-ID: <20090916182057.GF15451@mit.edu> (raw)
In-Reply-To: <4AADFC1A.7020609@rs.jp.nec.com>
On Mon, Sep 14, 2009 at 05:17:30PM +0900, Akira Fujita wrote:
> ext4: Fix different block exchange issue in EXT4_IOC_MOVE_EXT
>
> From: Akira Fujita <a-fujita@rs.jp.nec.com>
>
> If logical block offset of original file which is passed to
> EXT4_IOC_MOVE_EXT is different from donor file's,
> a calculation error occurs in ext4_calc_swap_extents(),
> therefore wrong block is exchanged between original file and donor file.
> As a result, we hit ext4_error() in check_block_validity().
> To detect the logical offset difference in EXT4_IOC_MOVE_EXT,
> add checks to mext_calc_swap_extents() and handle it as error,
> since data exchange must be done between the same blocks in EXT4_IOC_MOVE_EXT.
>
> Reported-by: Peng Tao <bergwolf@gmail.com>
> Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-09-16 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 8:17 [PATCH 4/4]ext4: Fix different block exchange issue in EXT4_IOC_MOVE_EXT Akira Fujita
2009-09-16 18:20 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916182057.GF15451@mit.edu \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=bergwolf@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.