From: Stephen Hemminger <shemminger@vyatta.com>
To: Greg KH <greg@kroah.com>, "Li, Charles" <Charles.Li@Micrel.Com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Choi@kroah.com, David <David.Choi@Micrel.Com>,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [PATCH] ks8851_ml ethernet network driver
Date: Wed, 16 Sep 2009 21:07:02 -0700 [thread overview]
Message-ID: <20090916210702.617b5069@s6510> (raw)
In-Reply-To: <20090917023836.GA15260@kroah.com>
On Wed, 16 Sep 2009 19:38:36 -0700
Greg KH <greg@kroah.com> wrote:
> +
> +/**
> + * ks_net_open - open network device
> + * @netdev: The network device being opened.
> + *
> + * Called when the network device is marked active, such as a user executing
> + * 'ifconfig up' on the device.
> + */
> +static int ks_net_open(struct net_device *netdev)
> +{
> + struct ks_net *ks = netdev_priv(netdev);
> + int err;
> +
> +#define KS_INT_FLAGS (IRQF_DISABLED|IRQF_TRIGGER_LOW)
> + /* lock the card, even if we may not actually do anything
> + * else at the moment.
> + */
> + mutex_lock(&ks->lock);
> +
I don't understand the purpose of ks->lock mutex. What is it
really protecting? open/close are already protected by rtnl_mutex,
is it really only for the PHY?
next prev parent reply other threads:[~2009-09-17 4:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 2:38 [PATCH] ks8851_ml ethernet network driver Greg KH
2009-09-17 3:48 ` David Miller
2009-09-17 13:03 ` Greg KH
2009-09-17 19:06 ` Choi, David
2009-09-17 19:30 ` Choi, David
2009-09-17 23:49 ` David Miller
2009-09-18 5:27 ` Greg KH
2009-09-24 23:02 ` [PATCH] ks8851_ml ethernet network driver - FIXED LINE-WRAPPING ISSUE Choi, David
2009-09-24 23:39 ` David Miller
2009-09-25 17:58 ` [PATCH] drivers/net: ks8851 ethernet network driver - RESUBMIT Choi, David
2009-09-25 19:09 ` David Miller
2009-09-26 0:42 ` [PATCH 2.6.31-rc9] drivers/net: ks8851_mll ethernet network driver Choi, David
2009-10-01 3:05 ` David Miller
2009-10-01 14:51 ` Choi, David
2009-09-17 4:03 ` [PATCH] ks8851_ml " Stephen Hemminger
2009-09-17 19:11 ` Choi, David
2009-09-17 4:07 ` Stephen Hemminger [this message]
2009-09-17 19:20 ` Choi, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916210702.617b5069@s6510 \
--to=shemminger@vyatta.com \
--cc=Charles.Li@Micrel.Com \
--cc=Choi@kroah.com \
--cc=David.Choi@Micrel.Com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.