From: Arnd Bergmann <arnd@arndb.de>
To: Caveh Jalali <ecaveh@gmail.com>
Cc: sam@ravnborg.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] Makefile: can't build modules outside the kernel tree if it was built using O=
Date: Thu, 17 Sep 2009 13:45:30 +0200 [thread overview]
Message-ID: <200909171345.30988.arnd@arndb.de> (raw)
In-Reply-To: <830a8fa70909161930r518a9644ja954ced2ae5814b4@mail.gmail.com>
On Thursday 17 September 2009, Caveh Jalali wrote:
> when the platform specific include directories were shuffled around
> without updating the
> top level Makefile. however, i think this FAIL is generic, and not
> limited to powerpc.
> here's a patch to the top level Makefile to teach it about the shuffled files:
>
>
> --- /local/caveh/linux/linux-2.6.31/Makefile 2009-09-09
> 15:13:59.000000000 -0700
> +++ Makefile 2009-09-16 12:23:05.000000000 -0700
> @@ -958,9 +958,9 @@ ifneq ($(KBUILD_SRC),)
> echo " in the '$(srctree)' directory.";\
> /bin/false; \
> fi;
> - $(Q)if [ ! -d include2 ]; then \
> - mkdir -p include2; \
> - ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; \
> + $(Q)if [ ! -d include2 ]; then \
> + mkdir -p include2; \
> + ln -fsn $(srctree)/arch/$(SRCARCH)/include/asm include2/asm; \
> fi
> endif
I think we should no longer have the include2 directory at all with new kernels.
LINUXINCLUDE already contains the right path in theory:
LINUXINCLUDE := -Iinclude \
$(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
-I$(srctree)/arch/$(hdr-arch)/include \
-include include/linux/autoconf.h
I'm not sure what goes wrong here. What is the gcc command line you see?
Arnd <><
next prev parent reply other threads:[~2009-09-17 11:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 2:30 [patch] Makefile: can't build modules outside the kernel tree if it was built using O= Caveh Jalali
2009-09-17 2:30 ` Caveh Jalali
2009-09-17 3:15 ` Américo Wang
2009-09-17 3:15 ` Américo Wang
2009-09-17 4:40 ` Caveh Jalali
2009-09-17 4:40 ` Caveh Jalali
2009-09-17 11:45 ` Arnd Bergmann [this message]
2009-09-17 21:49 ` Caveh Jalali
2009-09-17 21:49 ` Caveh Jalali
2009-09-18 9:28 ` Arnd Bergmann
2009-09-18 11:15 ` Arnd Bergmann
2009-09-18 1:49 ` Américo Wang
2009-09-18 1:49 ` Américo Wang
2009-09-18 4:52 ` Sam Ravnborg
2009-09-21 14:37 ` [PATCH] warn about use of uninstalled kernel headers Arnd Bergmann
2009-09-22 4:43 ` Sam Ravnborg
2009-09-22 13:09 ` Arnd Bergmann
2009-09-27 8:44 ` Sam Ravnborg
2009-09-19 9:06 ` [patch] Makefile: can't build modules outside the kernel tree if it was built using O= Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909171345.30988.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=ecaveh@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.