All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: test for "spurious" IRQ ignores possible IRQ_WAKE_THREAD value
Date: Fri, 18 Sep 2009 00:18:13 +0400	[thread overview]
Message-ID: <20090917201813.GG8817@lenovo> (raw)
In-Reply-To: <alpine.LFD.2.00.0909171605320.5014@localhost>

[Robert P. J. Day - Thu, Sep 17, 2009 at 04:08:32PM -0400]
...
| > Hi Robert,
| >
| > It could that IRQ_WAKE_THREAD is just missed here. I suppose it was
| > brough there as thread irq merged. But I think only Thomas know for
| > sure, I definitely miss something :) CC'ed
| 
|   actually, after a bit more reading, i found this in
| kernel/irq/handle.c:
|                 ...
|                 switch (ret) {
|                 case IRQ_WAKE_THREAD:
|                         /*
|                          * Set result to handled so the spurious check
|                          * does not trigger.
|                          */
|                         ret = IRQ_HANDLED;
|                         ...
| 
| so it looks like that value of IRQ_WAKE_THREAD is simply "mapped" to
| IRQ_HANDLED, and perhaps that's done before __report_bad_irq is ever
| called so that that latter routine never sees a value of
| IRQ_WAKE_THREAD.  but that's just a guess.
| 
| rday
| --

yeah, Thomas just pointed it too :) The note_interrupt is
called after handle_IRQ_event (except a few drivers which
don;t use threaded irq) so it doesnt reach bad irq state
with IRQ_WAKE_THREAD, for now at least.

	-- Cyrill

      reply	other threads:[~2009-09-17 20:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 20:30 test for "spurious" IRQ ignores possible IRQ_WAKE_THREAD value Robert P. J. Day
2009-09-14 20:34 ` Robert P. J. Day
2009-09-17 19:34   ` Cyrill Gorcunov
2009-09-17 19:52     ` Thomas Gleixner
2009-09-17 20:08     ` Robert P. J. Day
2009-09-17 20:18       ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090917201813.GG8817@lenovo \
    --to=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.