From: Andrew Morton <akpm@linux-foundation.org>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ar9170: implement frequency calibration for one-stage/openfw
Date: Fri, 18 Sep 2009 17:02:11 -0700 [thread overview]
Message-ID: <20090918170211.8acce2cc.akpm@linux-foundation.org> (raw)
In-Reply-To: <200909032025.31260.chunkeey@googlemail.com>
On Thu, 3 Sep 2009 20:25:31 +0200
Christian Lamparter <chunkeey@googlemail.com> wrote:
> This patch ports some code from the vendor driver, which is
> supposed to upload the right calibration values for the
> chosen frequency.
>
> In theory, this should give a better range and throughput
> for all users with the open, or one-stage firmware.
>
> ...
>
> + for (i = 0; i < 76; i++) {
> + u32 phy_data;
> + u8 tmp;
> +
> + if (i < 25) {
> + tmp = ar9170_interpolate_val(i, &pwrs[0][0],
> + &vpds[0][0]);
> + } else {
> + tmp = ar9170_interpolate_val(i - 12,
> + &pwrs[1][0],
> + &vpds[1][0]);
> + }
> +
> + phy_data |= tmp << ((i & 3) << 3);
Clearly buggy and the compiler warns. The value of phy_data is unknown
here.
How did this get all the way into mainline?
next prev parent reply other threads:[~2009-09-19 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 18:25 [PATCH] ar9170: implement frequency calibration for one-stage/openfw Christian Lamparter
2009-09-19 0:02 ` Andrew Morton [this message]
2009-09-19 12:21 ` Joerg Albert
2009-09-28 18:41 ` John W. Linville
2009-09-28 19:45 ` Christian Lamparter
2009-09-28 19:50 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918170211.8acce2cc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.