[Cluster-devel] [PATCH] dlm: fix lowcomms_connect_node for sctp

[David Teigland <teigland@redhat.com>]

On Fri, Sep 18, 2009 at 02:39:06PM -0500, David Teigland wrote:
> The recently added dlm_lowcomms_connect_node() from
> 391fbdc5d527149578490db2f1619951d91f3561 does not work
> when using SCTP instead of TCP.  The sctp connection code
> has nothing to do without data to send.  Check for no data
> in the sctp connection code and do nothing instead of
> triggering a BUG.  Also have connect_node() do nothing
> when the protocol is sctp.

With this patch I can use sctp (single interface), but I'm getting these
alloc_fd errors (which seem harmless enough) have you seen them before?

Also, gfs is *really* slow using sctp!

dlm: Using SCTP for communications
SCTP: Hash tables configured (established 58254 bind 58254)
dlm: foo: joining the lockspace group...
dlm: got new/restarted association 1 nodeid 4
dlm: foo: group event done 0 0
dlm: foo: recover 1
dlm: foo: add member 5
dlm: foo: add member 4
dlm: foo: add member 2
dlm: Initiating association with node 2
alloc_fd: slot 0 not NULL!
dlm: got new/restarted association 2 nodeid 2
dlm: foo: join complete
GFS2: fsid=bull:foo.2: Joined cluster. Now mounting FS...
dlm: foo: total members 3 error 0
dlm: foo: dlm_recover_directory
dlm: foo: dlm_recover_directory 13 entries