All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Karsten Keil <isdn@linux-pingi.de>, Karsten Keil <keil@b1-systems.de>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
	davem@davemloft.net, i4ldeveloper@listserv.isdn4linux.de,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 03/12] gigaset: linearize skb
Date: Sat, 19 Sep 2009 01:57:43 +0200 (CEST)	[thread overview]
Message-ID: <20090919-patch-gigaset-03.tilman@imap.cc> (raw)
In-Reply-To: <20090919-patch-gigaset-00.tilman@imap.cc>

The code of the Gigaset driver assumes that sk_buff-s coming
from the ISDN4Linux subsystem are always linear. Explicitly
calling skb_linearize() is cheap if they are, but much more
robust in case they ever aren't.

Impact: robustness improvement
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
---
 drivers/isdn/gigaset/i4l.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c
index 9b22f9c..322f16e 100644
--- a/drivers/isdn/gigaset/i4l.c
+++ b/drivers/isdn/gigaset/i4l.c
@@ -51,6 +51,12 @@ static int writebuf_from_LL(int driverID, int channel, int ack,
 		return -ENODEV;
 	}
 	bcs = &cs->bcs[channel];
+
+	/* can only handle linear sk_buffs */
+	if (skb_linearize(skb) < 0) {
+		dev_err(cs->dev, "%s: skb_linearize failed\n", __func__);
+		return -ENOMEM;
+	}
 	len = skb->len;
 
 	gig_dbg(DEBUG_LLDATA,
-- 
1.6.2.1.214.ge986c


  parent reply	other threads:[~2009-09-19  0:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 23:57 [PATCH 00/12] Gigaset driver patches for 2.6.32 (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 08/12] gigaset: correct debugging output selection Tilman Schmidt
2009-09-18 23:57 ` [PATCH 10/12] gigaset: prepare for CAPI implementation (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 07/12] gigaset: improve error recovery (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 04/12] gigaset: handle isoc frame errors more gracefully Tilman Schmidt
2009-09-18 23:57 ` [PATCH 01/12] gigaset: really fix chars_in_buffer Tilman Schmidt
2009-09-18 23:57 ` [PATCH 05/12] gigaset: announce if built with debugging Tilman Schmidt
2009-09-18 23:57 ` [PATCH 12/12] gigaset: add Kernel CAPI interface (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 06/12] gigaset: fix device ERROR response handling (v2) Tilman Schmidt
2009-09-18 23:57 ` [PATCH 02/12] gigaset: fix reject/hangup handling Tilman Schmidt
2009-09-18 23:57 ` [PATCH 11/12] gigaset: allow building without I4L Tilman Schmidt
2009-09-18 23:57 ` [PATCH 09/12] gigaset: add kerneldoc comments Tilman Schmidt
2009-09-18 23:57 ` Tilman Schmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-09-06 18:58 [PATCH 00/12] Gigaset driver patches for 2.6.32 Tilman Schmidt
2009-09-06 18:58 ` [PATCH 03/12] gigaset: linearize skb Tilman Schmidt
2009-09-06 18:58   ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090919-patch-gigaset-03.tilman@imap.cc \
    --to=tilman@imap.cc \
    --cc=davem@davemloft.net \
    --cc=hjlipp@web.de \
    --cc=i4ldeveloper@listserv.isdn4linux.de \
    --cc=isdn@linux-pingi.de \
    --cc=keil@b1-systems.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.