From: Sasha Khapyorsky <sashak@voltaire.com>
To: Keshetti Mahesh <keshetti.mahesh@gmail.com>
Cc: OFED mailing list <linux-rdma@vger.kernel.org>,
OFED mailing list <general@lists.openfabrics.org>
Subject: [ofa-general] Re: [PATCH][TRIVIAL] infiniband-diags/: Cosmetic changes, mostly typos
Date: Sat, 19 Sep 2009 20:58:32 +0300 [thread overview]
Message-ID: <20090919175832.GI13667@me> (raw)
In-Reply-To: <829ded920909150439h585f05e3hf0174713ecd2faf4@mail.gmail.com>
On 17:09 Tue 15 Sep , Keshetti Mahesh wrote:
> Cosmetic changes
>
> Signed-off-by: Keshetti Mahesh < keshetti.mahesh@gmail.com>
The patch is malformed (broken long lines and mangled whitespaces).
Applied by hands. Thanks.
Sasha
> ---
>
> diff --git a/infiniband-diags/scripts/ibcheckwidth.in
> b/infiniband-diags/scripts/ibcheckwidth.in
> index 6b723c5..cbb154c 100644
> --- a/infiniband-diags/scripts/ibcheckwidth.in
> +++ b/infiniband-diags/scripts/ibcheckwidth.in
> @@ -77,7 +77,7 @@ BEGIN {
> function check_node(lid)
> {
> nodechecked=1
> - if (system("'$IBPATH'/ibchecknode'"$ca_info"' '$gflags'
> '$verbose' " lid)) {
> + if (system("'$IBPATH'/ibchecknode '"$ca_info"' '$gflags'
> '$verbose' " lid)) {
> ne++
> badnode=1
> return
> @@ -113,7 +113,7 @@ function check_node(lid)
> }
> sub("\\(.*\\)", "", port)
> gsub("[\\[\\]]", "", port)
> - if (system("'$IBPATH'/ibcheckportwidth'"$ca_info"'
> '$gflags' '$verbose' " lid " " port)) {
> + if (system("'$IBPATH'/ibcheckportwidth '"$ca_info"'
> '$gflags' '$verbose' " lid " " port)) {
> if (!'$v' && oldlid != lid) {
> print "# Checked " ntype ": nodeguid
> 0x" nodeguid " with failure"
> oldlid = lid
> diff --git a/infiniband-diags/src/ibportstate.c
> b/infiniband-diags/src/ibportstate.c
> index 76e74f7..018bc9a 100644
> --- a/infiniband-diags/src/ibportstate.c
> +++ b/infiniband-diags/src/ibportstate.c
> @@ -349,7 +349,7 @@ int main(int argc, char **argv)
> get_port_info(&peerportid, data, peerlocalportnum,
> port_op);
> if (err < 0)
> - IBERROR("smp query peer portinfofailed");
> + IBERROR("smp query peer portinfo failed");
>
> mad_decode_field(data, IB_PORT_LINK_WIDTH_ENABLED_F,
> &peerlwe);
> diff --git a/infiniband-diags/man/ibcheckportwidth.8
> b/infiniband-diags/man/ibcheckportwidth.8
> index 85c06fc..c368467 100644
> --- a/infiniband-diags/man/ibcheckportwidth.8
> +++ b/infiniband-diags/man/ibcheckportwidth.8
> @@ -4,7 +4,7 @@
> ibcheckportwidth \- validate IB port for 1x link width
>
> .SH SYNOPSIS
> -.B ibcheckport
> +.B ibcheckportwidth
> [\-h] [\-v] [\-N | \-nocolor] [\-G] [\-C ca_name] [\-P ca_port]
> [\-t(imeout) timeout_ms] <lid|guid> <port>
> --
> 1.6.4.2
>
> --
> Keshetti Mahesh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-09-19 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 11:39 [PATCH][TRIVIAL] infiniband-diags/: Cosmetic changes, mostly typos Keshetti Mahesh
2009-09-19 17:58 ` Sasha Khapyorsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919175832.GI13667@me \
--to=sashak@voltaire.com \
--cc=general@lists.openfabrics.org \
--cc=keshetti.mahesh@gmail.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.