From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mp6hz-0000zd-3H for mharc-grub-devel@gnu.org; Sat, 19 Sep 2009 16:39:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mp6hx-0000z6-HM for grub-devel@gnu.org; Sat, 19 Sep 2009 16:39:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mp6ht-0000yX-4O for grub-devel@gnu.org; Sat, 19 Sep 2009 16:39:01 -0400 Received: from [199.232.76.173] (port=47993 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mp6hs-0000yU-VB for grub-devel@gnu.org; Sat, 19 Sep 2009 16:38:57 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51631 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mp6hs-0003P4-GU for grub-devel@gnu.org; Sat, 19 Sep 2009 16:38:56 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mp6hn-0002nm-Dt; Sat, 19 Sep 2009 22:38:51 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mp6hl-0004BX-W1; Sat, 19 Sep 2009 22:38:49 +0200 Date: Sat, 19 Sep 2009 22:38:49 +0200 From: Robert Millan To: Vladimir 'phcoder' Serbinenko Message-ID: <20090919203849.GD15672@thorin> References: <20090916194214.GA22363@thorin> <4AB4E6EB.4010307@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AB4E6EB.4010307@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: The development of GRUB 2 Subject: Re: -Werror and --disable-werror X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Sep 2009 20:39:01 -0000 On Sat, Sep 19, 2009 at 04:12:59PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > Hi, > > > > -Werror is not in effect. This will help ensuring that all new code is > > checked to be warning-free before commit (incidentally, I found a newly > > introduced bug thanks to this just minutes before enabling it). > > > > > If you mean this change: > > + /* Any value different than `p.offset' will satisfy the check during > + first loop. */ > + lastaddr = !p.offset; > + > > Then there was no bug here. > if (labeln && lastaddr == p.offset) > return grub_error (GRUB_ERR_BAD_PART_TABLE, "loop detected"); > > labeln++; > if ((labeln & (labeln - 1)) == 0) > lastaddr = p.offset; > > labeln is 0 during first loop run and then lastaddr is set. I explicitly > omitted initing variables to have smaller loop detector Oh, I see. Well, since in this case there's no bug, as long as the warning is gone it should be ok. Any other idea on how to archieve that? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."