From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCH] qemu-kvm: fix no gsi routing warning Date: Mon, 21 Sep 2009 17:51:37 +0300 Message-ID: <20090921145136.GA29405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: quintela@redhat.com, hch@lst.de To: kvm@vger.kernel.org, avi@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbZIUOx1 (ORCPT ); Mon, 21 Sep 2009 10:53:27 -0400 Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: When running on host kernel which does not let the guest manupulate the gsi routing, and user requested MSI-X to be enabled, we get the following warnings: kvm_msix_add: kvm_get_irq_route_gsi failed: No space left on device kvm_msix_update: kvm_update_routing_entry failed: Invalid argument What really happens is that we report a failure to allocate a vector to the guest, it will retry and finally disable MSI. Make this clearer by checking for gsi capability and warning about the error in a readable form. Reported-by: Juan Quintela Suggested-by: Christoph Hellwig Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index fcd425f..5695582 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -129,6 +129,13 @@ static int kvm_msix_add(PCIDevice *dev, unsigned vector) struct kvm_irq_routing_entry *entry = dev->msix_irq_entries + vector; int r; + if (!kvm_has_gsi_routing(kvm_context)) { + fprintf(stderr, "Warning: no MSI-X support found. " + "At least kernel 2.6.30 is required for MSI-X support.\n" + ); + return -EOPNOTSUPP; + } + r = kvm_get_irq_route_gsi(kvm_context); if (r < 0) { fprintf(stderr, "%s: kvm_get_irq_route_gsi failed: %s\n", __func__, strerror(-r)); -- 1.6.2.5