From mboxrd@z Thu Jan 1 00:00:00 1970 From: Craig Taylor Subject: Re: install does not obey DESTDIR or --prefix for perl modules Date: Mon, 21 Sep 2009 20:54:07 +0100 Message-ID: <20090921195407.GI8173@gryning.com> References: <20090921160551.GD8173@gryning.com> <7vskeguqmb.fsf@alter.siamese.dyndns.org> <20090921191943.GE8173@gryning.com> <7vocp4ulq2.fsf@alter.siamese.dyndns.org> Reply-To: c@gryning.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Brandon Casey , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Sep 21 21:54:23 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mpoxq-0006kH-1b for gcvg-git-2@lo.gmane.org; Mon, 21 Sep 2009 21:54:22 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbZIUTyM (ORCPT ); Mon, 21 Sep 2009 15:54:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753612AbZIUTyL (ORCPT ); Mon, 21 Sep 2009 15:54:11 -0400 Received: from 87-194-167-47.bethere.co.uk ([87.194.167.47]:59877 "EHLO jolt.ukmail.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbZIUTyK (ORCPT ); Mon, 21 Sep 2009 15:54:10 -0400 Received: from craigt by jolt.ukmail.org with local (Exim 4.63) (envelope-from ) id 1Mpoxb-0007Es-2a; Mon, 21 Sep 2009 20:54:07 +0100 Content-Disposition: inline In-Reply-To: <7vocp4ulq2.fsf@alter.siamese.dyndns.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, Sep 21, 2009 at 12:44:05PM -0700, Junio C Hamano wrote: > Craig Taylor writes: > > > Exactly as you describe here, different paths but same goal. > > All binaries follow the DESTDIR path except the perl modules. > > > > To register this as a bug do I need to do more than send this email? > > Do you use NO_PERL_MAKEMAKER in your build? > > If not, we need to summon an expert on ExtUtils::MakeMaker to look into > this issue, but if you do, perhaps you can try this patch and report how > well it works for you. > > --- > perl/Makefile | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/perl/Makefile b/perl/Makefile > index e3dd1a5..4ab21d6 100644 > --- a/perl/Makefile > +++ b/perl/Makefile > @@ -29,11 +29,11 @@ $(makfile): ../GIT-CFLAGS Makefile > '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ > echo ' cp private-Error.pm blib/lib/Error.pm' >> $@ > echo install: >> $@ > - echo ' mkdir -p "$(instdir_SQ)"' >> $@ > - echo ' $(RM) "$(instdir_SQ)/Git.pm"; cp Git.pm "$(instdir_SQ)"' >> $@ > - echo ' $(RM) "$(instdir_SQ)/Error.pm"' >> $@ > + echo ' mkdir -p "$$(DESTDIR)$(instdir_SQ)"' >> $@ > + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Git.pm"; cp Git.pm "$$(DESTDIR)$(instdir_SQ)"' >> $@ > + echo ' $(RM) "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ > '$(PERL_PATH_SQ)' -MError -e 'exit($$Error::VERSION < 0.15009)' || \ > - echo ' cp private-Error.pm "$(instdir_SQ)/Error.pm"' >> $@ > + echo ' cp private-Error.pm "$$(DESTDIR)$(instdir_SQ)/Error.pm"' >> $@ > echo instlibdir: >> $@ > echo ' echo $(instdir_SQ)' >> $@ > else I have 2 perl environments available to me on the system (at home now so can't dig further). Both can pretty stripped which can make thing "challenging" it's possible ExtUtils::MakeMaker doesn't even exist. Please everyone who is looking at this thread let it sleep for 24h and I shall test further/revive it tomorrow. Many thanks CraigT -- c^ [c%5e] Learn first whatever hardship you may have to endure is but temporary