Re: [PATCH] open.2: add some comments on O_SYNC and friends

[Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>]

On Sun, Sep 20, 2009 at 07:41:34AM +0200, Michael Kerrisk wrote:
> > -data is guaranteed to have been transferred.
> > +File I/O is done directly to/from user space buffers. ?The
> > +\fBO_DIRECT\fP flag alone does make at an effort to transfer
> > +data synchronously, but does not give the guarantees of the
> > +\fBO_SYNC\fP that data and nessecary data must be transferred.
> 
> Here I wrote "data and necessary metadata".
> Okay?

Yes.

> > ?POSIX provides for three different variants of synchronized I/O,
> > ?corresponding to the flags \fBO_SYNC\fP, \fBO_DSYNC\fP and
> > -\fBO_RSYNC\fP.
> > -Currently (2.1.130) these are all synonymous under Linux.
> > +\fBO_RSYNC\fP. ?Currently (2.6.31) Linux only implements the
> > +\fBO_SYNC\fP but glibc maps \fBO_DSYNC\fP and \fBO_SYNC\fP to
> > +the same numerical value.
> 
> Here, I made it
> 
>     but glibc maps O_DSYNC and O_RSYNC to
>     the same numerical value as O_SYNC.
> 
> Okay?

Yes, again much better than my version.

> Aside from the changes notes above, and some language clean-ups, I
> applied your patch as given, for man-pages-3.23.

Thanks a lot.  Note that in the meantime I sent patches to implement
real O_SYNC/O_DSYNC and I'll send you another update once they get
applied.

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html