From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nscott@aconex.com>
Cc: xfs@oss.sgi.com
Subject: Re: [patch] xfsprogs build tweaks for Debian
Date: Tue, 22 Sep 2009 07:57:07 -0400 [thread overview]
Message-ID: <20090922115707.GA8143@infradead.org> (raw)
In-Reply-To: <1527800797.273701253228929936.JavaMail.root@mail-au.aconex.com>
On Fri, Sep 18, 2009 at 09:08:49AM +1000, Nathan Scott wrote:
> Hi all,
>
> This patch allows deb packages to be generated more cleanly by Makepkgs
> than it currently allows. In particular, it handles the issue of having
> .git files in the generated tarball, and also puts the debs in build/deb
> when they're built, which is a bit more convenient and consistent.
The tarball generated by Makepks does not contain .git. Do you create
a tarball in a different way for debian?
> +++ b/Makefile
> @@ -9,9 +9,7 @@ ifeq ($(HAVE_BUILDDEFS), yes)
> include $(TOPDIR)/include/builddefs
> endif
>
> -CONFIGURE = aclocal.m4 configure config.guess config.sub configure install-sh \
> - ltmain.sh m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 \
> - m4/ltversion.m4 m4/lt~obsolete.m4
> +CONFIGURE = aclocal.m4 configure config.guess config.sub install-sh ltmain.sh
So configure was mentioned twice which is an obvious bug. But why do we
want to remove the m4/* files from the list of files to package?
[Ah, they're added inside the m4 directory, ok]
> type=rpm
> +[ -f /etc/debian_version ] && type=debian
would be cleaner as
#
# If we're on a Debian or Debian-derived system generate deb packages by
# default, else RPM packages.
#
if [ -f /etc/debian_version ]
type=debian
else
type=rpm
fi
> diff --git a/VERSION b/VERSION
> index b3a880e..6018818 100644
> --- a/VERSION
> +++ b/VERSION
> @@ -3,5 +3,5 @@
> #
> PKG_MAJOR=3
> PKG_MINOR=0
> -PKG_REVISION=3
> +PKG_REVISION=4
> PKG_BUILD=1
Note that when you bump package version please always also tag the
result in git.
> + - Debian packaging updates, esp. readline6 dependency.
Btw, didn't readline move to GPLv3 while we have GPLv2 code in libxfs?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-09-22 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <777659823.265181253164106522.JavaMail.root@mail-au.aconex.com>
2009-09-17 23:08 ` [patch] xfsprogs build tweaks for Debian Nathan Scott
2009-09-22 11:57 ` Christoph Hellwig [this message]
2009-09-22 12:15 ` Christoph Hellwig
2009-09-23 0:08 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922115707.GA8143@infradead.org \
--to=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.