From: Tony Lindgren <tony@atomide.com>
To: Olof Johansson <olof@lixom.net>
Cc: Ajay Kumar Gupta <ajay.gupta@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] usb: ehci-omap: Fix build break
Date: Tue, 22 Sep 2009 10:12:20 -0700 [thread overview]
Message-ID: <20090922171220.GF14890@atomide.com> (raw)
In-Reply-To: <20090922151140.GB8975@lixom.net>
* Olof Johansson <olof@lixom.net> [090922 07:55]:
> Fix build break:
>
> CC drivers/usb/host/ehci-hcd.o
> In file included from drivers/usb/host/ehci-hcd.c:1101:
> drivers/usb/host/ehci-omap.c: In function 'omap_start_ehc':
> drivers/usb/host/ehci-omap.c:238: error: 'CHIP_GE_OMAP3430ES3' undeclared (first use in this function)
> drivers/usb/host/ehci-omap.c:238: error: (Each undeclared identifier is reported only once
> drivers/usb/host/ehci-omap.c:238: error: for each function it appears in.)
> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
>
>
> No reference to CHIP_GE_OMAP3430ES3 anywhere else, I'm assuming it's
> ES3_1 that's supposed to be used.
I'm dropping the "ehci: Support for ES3.x" patch instead for now
until it's fixed to use the omap_rev().
So this should not be needed.
Tony
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index f77a99d..301e7b6 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -235,7 +235,7 @@ static void omap_usb_utmi_init(struct ehci_hcd_omap *omap, u8 tll_channel_mask)
> */
> static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
> {
> - struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3);
> + struct omap_chip_id oci = OMAP_CHIP_INIT(CHIP_GE_OMAP3430ES3_1);
> unsigned long timeout = jiffies + msecs_to_jiffies(1000);
> u8 tll_ch_mask = 0;
> unsigned reg = 0;
prev parent reply other threads:[~2009-09-22 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 15:11 [PATCH] usb: ehci-omap: Fix build break Olof Johansson
2009-09-22 17:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090922171220.GF14890@atomide.com \
--to=tony@atomide.com \
--cc=ajay.gupta@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.