All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-omap@vger.kernel.org, Ajay Kumar Gupta <ajay.gupta@ti.com>,
	sakoman@gmail.com
Subject: Re: [PATCH v2] omap2: ehci: Make Overo compile again
Date: Tue, 22 Sep 2009 10:15:27 -0700	[thread overview]
Message-ID: <20090922171527.GG14890@atomide.com> (raw)
In-Reply-To: <20090922161559.GA9767@lixom.net>

* Olof Johansson <olof@lixom.net> [090922 09:00]:
> Overo needs the same changes as the other platforms do for the ehci changes.
> 
> Also, roll in the corresponding change from Steve Sakoman fixing the
> port setup (removing the redundant GPIO setup and switching to port 2).
>
> Signed-off-by: Olof Johansson <olof@lixom.net>

Sakoman, does this look OK to you?

Tony

> 
> ---
> 
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 17f2318..75bdc09 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -384,6 +384,19 @@ static struct platform_device *overo_devices[] __initdata = {
>  	&overo_lcd_device,
>  };
>  
> +static struct ehci_hcd_omap_platform_data ehci_pdata __initconst = {
> +	.port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> +	.port_mode[1] = EHCI_HCD_OMAP_MODE_PHY,
> +	.port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN,
> +
> +	.chargepump = false,
> +	.phy_reset  = true,
> +	.reset_gpio_port[0]  = -EINVAL,
> +	.reset_gpio_port[1]  = OVERO_GPIO_USBH_NRESET,
> +	.reset_gpio_port[2]  = -EINVAL
> +};
> +
> +
>  static void __init overo_init(void)
>  {
>  	overo_i2c_init();
> @@ -391,7 +404,7 @@ static void __init overo_init(void)
>  	omap_serial_init();
>  	overo_flash_init();
>  	usb_musb_init();
> -	usb_ehci_init(EHCI_HCD_OMAP_MODE_PHY, false, true, 183, -EINVAL);
> +	usb_ehci_init(&ehci_pdata);
>  	overo_ads7846_init();
>  	overo_init_smsc911x();
>  
> @@ -434,14 +447,6 @@ static void __init overo_init(void)
>  	else
>  		printk(KERN_ERR "could not obtain gpio for "
>  					"OVERO_GPIO_USBH_CPEN\n");
> -
> -	if ((gpio_request(OVERO_GPIO_USBH_NRESET,
> -			  "OVERO_GPIO_USBH_NRESET") == 0) &&
> -	    (gpio_direction_output(OVERO_GPIO_USBH_NRESET, 1) == 0))
> -		gpio_export(OVERO_GPIO_USBH_NRESET, 0);
> -	else
> -		printk(KERN_ERR "could not obtain gpio for "
> -					"OVERO_GPIO_USBH_NRESET\n");
>  }
>  
>  static void __init overo_map_io(void)

  reply	other threads:[~2009-09-22 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 15:04 [PATCH] omap2: ehci: Make Overo compile again Olof Johansson
2009-09-22 16:15 ` [PATCH v2] " Olof Johansson
2009-09-22 17:15   ` Tony Lindgren [this message]
2009-09-22 17:33     ` Steve Sakoman
2009-09-22 17:36   ` [APPLIED] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090922171527.GG14890@atomide.com \
    --to=tony@atomide.com \
    --cc=ajay.gupta@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.