All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Chris Malley <mail@chrismalley.co.uk>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: perf sched record hangs machine
Date: Wed, 23 Sep 2009 12:41:00 +0200	[thread overview]
Message-ID: <20090923104100.GA23941@elte.hu> (raw)
In-Reply-To: <aa79d98a0909230248j22f05047n34e0ee97382f573f@mail.gmail.com>


* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 9/23/09, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Chris Malley <mail@chrismalley.co.uk> wrote:
> >
> >> 2009/9/23 Cyrill Gorcunov <gorcunov@gmail.com>:
> >> >
> >> > Btw, meanwhile Chris may try to pass lapic boot-option in attempt to
> >> > reenable apic via msr registers. Also (iirc) i feel we may be hiding
> >> > errors if complete noop apic would be used since i belive we need to
> >> > check out under which condition a particular operation is called and
> >> > when apic is disabled it's mean we're switched to UP mode and
> >> > inter-cpu interrupts are under suspicion too. Will take a look during
> >> > ~6 hours ;)
> >> >
> >>
> >> Hi Cyrill
> >>
> >> Heh, yes that just occurred to me as well.  With the lapic boot option
> >> I can't reproduce the problem, and get a good recording every time.
> >> Don't know why the BIOS had disabled it (can't see any specific
> >> option).
> >
> > Would still be important to fix the crash - there are boxes where lapics
> > are disabled permanently and cannot be re-enabled. (plus most people
> > dont touch their defaults and dont add funky boot options - so crashing
> > is not an option)
> >
> 
> Ingo, Chris, could you try Peter's patch? It seems like what we need.

It should fix the problem, but also the underlying uncleanliness should 
be fixed as well. We need an apic_none driver template with safe 
methods. Then all the scattered 'is the lapic enabled' open-coded checks 
of global flags can be removed.

	Ingo

  parent reply	other threads:[~2009-09-23 10:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 21:09 perf sched record hangs machine Chris Malley
2009-09-22 21:24 ` Frederic Weisbecker
2009-09-22 21:44   ` Frederic Weisbecker
2009-09-23  6:16   ` Peter Zijlstra
2009-09-23  7:32     ` Ingo Molnar
2009-09-23  7:40       ` Ingo Molnar
2009-09-23  7:44         ` Cyrill Gorcunov
2009-09-23  8:48           ` Cyrill Gorcunov
2009-09-23  8:52             ` Peter Zijlstra
2009-09-23  9:15             ` Chris Malley
2009-09-23  9:20               ` Ingo Molnar
2009-09-23  9:48                 ` Cyrill Gorcunov
2009-09-23 10:06                   ` Chris Malley
2009-09-23 10:12                     ` Cyrill Gorcunov
2009-09-23 10:42                     ` Ingo Molnar
2009-09-23 11:41                       ` Chris Malley
2009-09-23 11:42                         ` Ingo Molnar
2009-09-23 12:20                           ` Chris Malley
2009-09-23 12:27                             ` Ingo Molnar
2009-09-23 10:41                   ` Ingo Molnar [this message]
2009-09-23  9:03       ` Peter Zijlstra
2009-09-23 11:49 ` [tip:perf/urgent] perf_event, x86: Fix 'perf sched record' crashing the machine tip-bot for Peter Zijlstra
2009-09-23 12:15   ` Chris Malley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090923104100.GA23941@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@chrismalley.co.uk \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.