All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mroth@nessie.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Rename BASE_DIR to OUTPUT_DIR
Date: Wed, 23 Sep 2009 12:37:52 +0200	[thread overview]
Message-ID: <200909231237.58227.mroth@nessie.de> (raw)
In-Reply-To: <878wg6rmes.fsf@macbook.be.48ers.dk>

Am Wednesday 23 September 2009 12:22:03 schrieb Peter Korsgaard:
> >>>>> "Michael" == Michael Roth <mroth@nessie.de> writes:
>
>  Michael> To reflect the new output directory hierarchy rename the Makefile
>  Michael> variable BASE_DIR to OUTPUT_DIR.
>
>  Michael> Signed-off-by: Michael Roth <mroth@nessie.de>
>
> Hmm, this will presumably break downloads for people trying to reuse
> their existing .config? (E.G. DL_DIR gets to point to /dl).

Hmm... Yes, I think you're right.


> I agree that BASE_DIR isn't the most telling name for what it does, but
> I'm not sure it's worth the trouble.

OTOH: The introduced change to the directory hierarchy "broke" the download 
directory from '$(TOPDIR)/dl' to '$(TOPDIR)/output/dl'.

Maybe the directory hierarchy change introduced some other inconvenience so
maybe a big fat warning that some things changed in the documentation is the 
way to go?

Or, maybe a hook in 'make oldconfig' could fix that?


Michael Roth

  reply	other threads:[~2009-09-23 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 10:03 [Buildroot] [PATCH] Rename BASE_DIR to OUTPUT_DIR Michael Roth
2009-09-23 10:22 ` Peter Korsgaard
2009-09-23 10:37   ` Michael Roth [this message]
2009-09-23 11:09     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909231237.58227.mroth@nessie.de \
    --to=mroth@nessie.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.