All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] vxworks: Add CONFIG_VXWORKS_PREBOOT
Date: Wed, 23 Sep 2009 14:56:16 +0200	[thread overview]
Message-ID: <200909231456.16526.sr@denx.de> (raw)
In-Reply-To: <1253686958-30716-1-git-send-email-niklaus.giger@netstal.com>

Hi Niklas,

On Wednesday 23 September 2009 08:22:38 Niklaus Giger wrote:
> The option CONFIG_VXWORKS_PREBOOT allows a board specific
> vxworks_preboot to be run just before jumping into the
> vxWorks images. This can be used to alter a register
> which is used differently by U-boot and vxWorks.
> 
> Signed-off-by: Niklaus Giger <niklaus.giger@netstal.com>
> ---
>  common/cmd_elf.c  |    4 ++++
>  include/vxworks.h |    4 ++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_elf.c b/common/cmd_elf.c
> index bf7dd63..4e36680 100644
> --- a/common/cmd_elf.c
> +++ b/common/cmd_elf.c
> @@ -213,6 +213,10 @@ int do_bootvx (cmd_tbl_t *cmdtp, int flag, int argc,
>  char *argv[]) (char *) bootaddr);
>  	printf ("## Starting vxWorks at 0x%08lx ...\n", addr);
> 
> +#ifdef CONFIG_VXWORKS_PREBOOT
> +    vxworks_preboot();
> +#endif

We could get rid of this #ifdef by using an empty weak default function for 
this.

And it seems that you have an indentation problem here.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  parent reply	other threads:[~2009-09-23 12:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23  6:22 [U-Boot] [PATCH] vxworks: Add CONFIG_VXWORKS_PREBOOT Niklaus Giger
2009-09-23 11:39 ` Tom
2009-09-23 12:48   ` Niklaus Giger
2009-09-23 13:00     ` Tom
2009-09-23 12:56 ` Stefan Roese [this message]
2009-09-23 13:02 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909231456.16526.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.