All of lore.kernel.org
 help / color / mirror / Atom feed
From: iceberg <strakh@ispras.ru>
To: James.Bottomley@hansenpartnership.com, eric@andante.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scsi_lib.c: sleeping function called from invalid context
Date: Wed, 23 Sep 2009 17:58:47 +0000	[thread overview]
Message-ID: <200909231758.47612.strakh@ispras.ru> (raw)

Driver scsi_lib.c might sleep in atomic context, because it calls 
scsi_device_put under spin_lock_irqsave.
drivers/scsi/scsi_lib.c:356:
	spin_lock_irqsave(shost->host_lock, flags);
	scsi_device_put(sdev);
Path to might_sleep macro from scsi_device_put:
1. scsi_device_put calls put_device at ./drivers/scsi/scsi.c:1111 
2. put_device calls kobject_put at ./drivers/base/core.c:1038 
3. kobject_put calls kref_put at ./lib/kobject.c
4. kref_put may call callback function kobject_release at ./lib/kref.c if 
refcount becomes zero, which might_sleep because it calls user event. Details:
	4.1 kobject_cleanup calls kobject_uevent at ./lib/kobject.c:555
	4.2 kobject_uevent calls kobject_uevent_env at  ./lib/kobject_uevent.c:282
	4.3 kobject_uevent_env calls call_usermodehelper_exec at 
./include/linux/kmod.h:83
	4.4 call_usermodehelper_exec calls wait_for_completion at 
./kernel/kmod.c:481
	4.5 wait_for_completion calls wait_for_common at ./kernel/sched.c:5710
	4.5 wait_for_common calls might_sleep at ./kernels/sched.c:5692

Found by Linux Driver Verification project.

Delete wrong sleeping function calls.

Signed-off-by: Alexander Strakh <strakh@ispras.ru>

---
diff --git a/./a/drivers/scsi/scsi_lib.c b/./b/drivers/scsi/scsi_lib.c
index f3c4089..a8f8e2f 100644
--- a/./a/drivers/scsi/scsi_lib.c
+++ b/./b/drivers/scsi/scsi_lib.c
@@ -353,9 +353,9 @@ static void scsi_single_lun_run(struct scsi_device 
*current_sdev)
 
 		spin_unlock_irqrestore(shost->host_lock, flags);
 		blk_run_queue(sdev->request_queue);
-		spin_lock_irqsave(shost->host_lock, flags);
 	
-		scsi_device_put(sdev);
+		scsi_device_put(sdev);	
+		spin_lock_irqsave(shost->host_lock, flags);
 	}
  out:
 	spin_unlock_irqrestore(shost->host_lock, flags);


             reply	other threads:[~2009-09-23 13:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 17:58 iceberg [this message]
2009-09-24 22:56 ` [PATCH] scsi_lib.c: sleeping function called from invalid context Andrew Morton
2009-09-25  1:23   ` James Bottomley
2009-10-01 18:32     ` James Bottomley
2009-10-05 18:35       ` iceberg
2009-10-05 18:35         ` iceberg
2009-10-05 15:13         ` James Bottomley
2009-10-06 12:30           ` iceberg
2009-10-06 12:30             ` iceberg
2009-10-06 13:50             ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2009-09-23 17:54 iceberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909231758.47612.strakh@ispras.ru \
    --to=strakh@ispras.ru \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=eric@andante.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.