[Qemu-devel] Re: comments on: get page size in device init

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Sep 23, 2009 at 01:02:56PM -0500, Anthony Liguori wrote:
> Blue Swirl wrote:
>> On Wed, Sep 23, 2009 at 3:58 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>>   
>>>>     Compile msix only once
>>>>
>>>>     Get page size in device init.
>>>>
>>>>     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>>>>       
>>> What was the motivation for the page size change?
>>>     
>>
>> "Compile msix only once"
>>
>>   
>>> It seems the only user passes TARGET_PAGE_SIZE anyway,
>>> using a constant seems clearer and probably generates
>>> less code. No?
>>>     
>>
>> Yes, but then the code would depend on TARGET_PAGE_SIZE, making it
>> impossible to compile the code only once.
>>   
>
> We could probably get away with doing
>
> #define TARGET_PAGE_SIZE target_get_page_size()
>
> And take care of a big chunk of this without passing page size  
> parameters around.


Sounds good.

> Regards,
>
> Anthony Liguori