From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Stable Kernel <stable@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [GIT PULL] xen: Check NX state before setting up GDT mapping
Date: Wed, 23 Sep 2009 21:13:15 +0200 [thread overview]
Message-ID: <20090923191315.GA14437@elte.hu> (raw)
In-Reply-To: <4ABA7119.6000307@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On 09/23/09 05:36, Ingo Molnar wrote:
> >> +#ifdef CONFIG_X86_64
> >> + /* Work out if we support NX */
> >> + check_efer();
> >> +#endif
> >> +
> >>
> > btw., this #ifdef could sure be eliminated, right?
> >
>
> check_efer() is only defined on x86-64 and all its existing callsites
> have a similar #ifdef.
Yes, a familar pattern that prompted my comment.
> [...] NX setup is an area which could do with a bit of hitting with
> the unification stick.
Yes.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen-devel <xen-devel@lists.xensource.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Stable Kernel <stable@kernel.org>
Subject: Re: [GIT PULL] xen: Check NX state before setting up GDT mapping
Date: Wed, 23 Sep 2009 21:13:15 +0200 [thread overview]
Message-ID: <20090923191315.GA14437@elte.hu> (raw)
In-Reply-To: <4ABA7119.6000307@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> On 09/23/09 05:36, Ingo Molnar wrote:
> >> +#ifdef CONFIG_X86_64
> >> + /* Work out if we support NX */
> >> + check_efer();
> >> +#endif
> >> +
> >>
> > btw., this #ifdef could sure be eliminated, right?
> >
>
> check_efer() is only defined on x86-64 and all its existing callsites
> have a similar #ifdef.
Yes, a familar pattern that prompted my comment.
> [...] NX setup is an area which could do with a bit of hitting with
> the unification stick.
Yes.
Ingo
next prev parent reply other threads:[~2009-09-23 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 21:11 [GIT PULL] xen: Check NX state before setting up GDT mapping Jeremy Fitzhardinge
2009-09-21 21:11 ` Jeremy Fitzhardinge
2009-09-23 12:35 ` Ingo Molnar
2009-09-23 12:35 ` Ingo Molnar
2009-09-23 12:36 ` Ingo Molnar
2009-09-23 12:36 ` Ingo Molnar
2009-09-23 19:03 ` Jeremy Fitzhardinge
2009-09-23 19:03 ` Jeremy Fitzhardinge
2009-09-23 19:13 ` Ingo Molnar [this message]
2009-09-23 19:13 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923191315.GA14437@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.