From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mqn1v-0002Nk-Vp for mharc-grub-devel@gnu.org; Thu, 24 Sep 2009 08:02:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mqn1r-0002Lo-Er for grub-devel@gnu.org; Thu, 24 Sep 2009 08:02:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mqn1k-0002Ik-PL for grub-devel@gnu.org; Thu, 24 Sep 2009 08:02:29 -0400 Received: from [199.232.76.173] (port=47310 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mqn1k-0002IZ-J6 for grub-devel@gnu.org; Thu, 24 Sep 2009 08:02:24 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:54343 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mqn1k-0002Fh-1e for grub-devel@gnu.org; Thu, 24 Sep 2009 08:02:24 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mqn1f-0006Aq-V2 for grub-devel@gnu.org; Thu, 24 Sep 2009 14:02:20 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mqn1f-0001Li-4X for grub-devel@gnu.org; Thu, 24 Sep 2009 14:02:19 +0200 Date: Thu, 24 Sep 2009 14:02:19 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090924120219.GA4558@thorin> References: <4ab7a42f.8353f10a.25a9.4896SMTPIN_ADDED@mx.google.com> <4AB841B9.30708@gmail.com> <4AB88317.1070603@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AB88317.1070603@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: patch to replace (UUID=) hack X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2009 12:02:32 -0000 On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Try attached WIP patch Excellent. This was quite necessary. I have to admit my (UUID=) kludge was a really poor solution (although in that time, the alternatives weren't so straightforwarded). I'm inclined to allow this for inclusion in 1.97, since it fixes a problem that could be seen as a bug (the overhead can be huge, specially in slow setups). > - prefix_drive="(UUID=${uuid})" > - modules="$modules fs_uuid" > + config="search_fs_uuid ${uuid} root" > + modules="$modules search_fs_uuid" Note we don't need to explicitly include "root" there. This would save 5 bytes, and make the behaviour a bit more consistent (since root is implicit afterwards). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."