From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MqnGs-0006T9-HG for mharc-grub-devel@gnu.org; Thu, 24 Sep 2009 08:18:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqnGi-0006Qo-DH for grub-devel@gnu.org; Thu, 24 Sep 2009 08:17:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqnGc-0006P8-Jg for grub-devel@gnu.org; Thu, 24 Sep 2009 08:17:50 -0400 Received: from [199.232.76.173] (port=49930 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqnGb-0006Ow-B2 for grub-devel@gnu.org; Thu, 24 Sep 2009 08:17:45 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:44135 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqnGa-0005Nh-Uk for grub-devel@gnu.org; Thu, 24 Sep 2009 08:17:45 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MqnGZ-0006C4-Io for grub-devel@gnu.org; Thu, 24 Sep 2009 14:17:43 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MqnGW-0001QE-V5 for grub-devel@gnu.org; Thu, 24 Sep 2009 14:17:40 +0200 Date: Thu, 24 Sep 2009 14:17:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090924121740.GF4558@thorin> References: <4AB91FB8.7000107@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Save boot record before writing to the dest_drive X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2009 12:17:54 -0000 On Wed, Sep 23, 2009 at 07:38:59AM +0530, kashyap garimella wrote: > There is already a thread discussing this topic. > http://www.mail-archive.com/grub-devel@gnu.org/msg12829.html > The patch saves the exact places in embed region, which are overwritten. > And it restores the mbr+embed region safely. Your patch has some indentation issues. Please can you run the indent program on it? Also, please include a ChangeLog entry. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."