Re: [PATCH] regulator: add driver for MAX8660/8661

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Sep 24, 2009 at 03:24:05PM +0200, Wolfram Sang wrote:
> Tested with a MX25-based custom board.

> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

This looks good - thanks!  A couple of little comments below:

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> +	if (MAX8660_DCDC_MIN_UV + selector * MAX8660_DCDC_STEP > max_uV)
> +		return -EINVAL;

Not important but using list_voltage() here would be a little nicer.

> +static struct regulator_ops max8660_dcdc_ops = {
> +	.is_enabled = max8660_dcdc_is_enabled,
> +	.list_voltage = max8660_dcdc_list,
> +	.set_voltage = max8660_dcdc_set,
> +	.get_voltage = max8660_dcdc_get,
> +	/* no set_mode() & friends: forced PWM does not save any power */

Forced PWM is normally a power loss - the benefit it gives is the
ability to respond to sudden spikes in load without voltage droops.  The
power benefit from not having it enabled is usually only apparent at
lower loads.