All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	LKML <linux-kernel@vger.kernel.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [GIT PULL v2] bkl tracepoints + filter regex support
Date: Fri, 25 Sep 2009 09:55:30 +0200	[thread overview]
Message-ID: <20090925075528.GC4700@nowhere> (raw)
In-Reply-To: <20090924202225.GA15108@elte.hu>

On Thu, Sep 24, 2009 at 10:22:25PM +0200, Ingo Molnar wrote:
> 
> also, some build problems:
> 
> include/trace/events/bkl.h: In function 
> ?ftrace_profile_enable_lock_kernel?:
> include/trace/events/bkl.h:9: error: implicit declaration of function 
> ?register_trace_lock_kernel?
> include/trace/events/bkl.h: In function 
> ?ftrace_profile_disable_lock_kernel?:
> include/trace/events/bkl.h:9: error: implicit declaration of function 
> ?unregister_trace_lock_kernel?
> include/trace/events/bkl.h: In function 
> ?ftrace_profile_enable_unlock_kernel?:
> include/trace/events/bkl.h:34: error: implicit declaration of function 
> ?register_trace_unlock_kernel?
> include/trace/events/bkl.h: In function 
> ?ftrace_profile_disable_unlock_kernel?:
> include/trace/events/bkl.h:34: error: implicit declaration of function 
> ?unregister_trace_unlock_kernel?
> 
> config attached.
> 
> 	Ingo


Ok, I see. The problem is that include/ftrace_event.h includes hardirq.h
which includes smp_lock.h, then each time we define another tracepoint, we
redefine the bkl tracepoints.

Thanks, I'll fix this.


  reply	other threads:[~2009-09-25  7:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 19:49 [GIT PULL v2] bkl tracepoints + filter regex support Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 1/5 v2] tracing/bkl: Add bkl ftrace events Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 2/5 v2] tracing/filters: Cleanup useless headers Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 3/5 v2] tracing/event: Cleanup the useless dentry variable Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 4/5 v2] tracing/filters: Provide basic regex support Frederic Weisbecker
2009-09-25  8:13   ` Andrey Panin
2009-09-25  8:16     ` Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 5/5] tracing/filters: Unify the regex parsing helpers Frederic Weisbecker
2009-09-24 20:15 ` [GIT PULL v2] bkl tracepoints + filter regex support Ingo Molnar
2009-09-24 20:16   ` Ingo Molnar
2009-09-24 20:22     ` Ingo Molnar
2009-09-25  7:55       ` Frederic Weisbecker [this message]
2009-09-24 20:30     ` Peter Zijlstra
2009-09-24 20:44       ` Frederic Weisbecker
2009-09-24 20:51         ` Peter Zijlstra
2009-09-24 21:36           ` Frederic Weisbecker
2009-09-25  8:19             ` Peter Zijlstra
2009-09-25  9:12               ` Frederic Weisbecker
2009-09-25  9:40                 ` Peter Zijlstra
2009-09-25 10:38                   ` Frederic Weisbecker
2009-09-26 10:44                     ` Steven Rostedt
2009-10-03 11:36                       ` Frederic Weisbecker
2009-09-26 15:47                     ` Frank Ch. Eigler
2009-10-03 11:49                       ` Frederic Weisbecker
2009-09-26 10:30                   ` Steven Rostedt
2009-09-24 20:33     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090925075528.GC4700@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.