From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MrBZ1-0006z8-U0 for mharc-grub-devel@gnu.org; Fri, 25 Sep 2009 10:14:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrBYz-0006yk-JD for grub-devel@gnu.org; Fri, 25 Sep 2009 10:14:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrBYu-0006xr-P3 for grub-devel@gnu.org; Fri, 25 Sep 2009 10:14:20 -0400 Received: from [199.232.76.173] (port=44465 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrBYu-0006xl-EE for grub-devel@gnu.org; Fri, 25 Sep 2009 10:14:16 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:59048 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrBYt-0007E2-PZ for grub-devel@gnu.org; Fri, 25 Sep 2009 10:14:16 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MrBYi-0003Bf-PS for grub-devel@gnu.org; Fri, 25 Sep 2009 16:14:05 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MrBYh-0001fu-Lb for grub-devel@gnu.org; Fri, 25 Sep 2009 16:14:03 +0200 Date: Fri, 25 Sep 2009 16:14:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090925141403.GA6401@thorin> References: <4ab7a42f.8353f10a.25a9.4896SMTPIN_ADDED@mx.google.com> <4AB841B9.30708@gmail.com> <4AB88317.1070603@gmail.com> <20090924120219.GA4558@thorin> <4ABCAA2A.7010807@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ABCAA2A.7010807@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: patch to replace (UUID=) hack X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2009 14:14:22 -0000 On Fri, Sep 25, 2009 at 01:31:54PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Tue, Sep 22, 2009 at 09:56:07AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > >> Try attached WIP patch > >> > > > > Excellent. This was quite necessary. I have to admit my (UUID=) kludge was > > a really poor solution (although in that time, the alternatives weren't > > so straightforwarded). > > > > I'm inclined to allow this for inclusion in 1.97, since it fixes a problem > > that could be seen as a bug (the overhead can be huge, specially in slow > > setups). > > > > > This patch isn't ready yet. grub-install has to be fixed for > grub-install for sparc64 too but I have no possibility to test it on > sparc64. I haven't tested it on multi-drive config on x86 yet. This code duplication is problematic. Would be nice to have those two files unified in long term :-/ > >> - prefix_drive="(UUID=${uuid})" > >> - modules="$modules fs_uuid" > >> + config="search_fs_uuid ${uuid} root" > >> + modules="$modules search_fs_uuid" > >> > > > > Note we don't need to explicitly include "root" there. This would save 5 > > bytes, and make the behaviour a bit more consistent (since root is > > implicit afterwards). > > > > If "root" is omitted the found filename is printed on console I guess that's because -s wasn't used? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."