All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Maciej Rutecki <maciej.rutecki@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	clemens@ladisch.de, venkatesh.pallipadi@intel.com,
	gregkh@suse.de
Subject: Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
Date: Sun, 27 Sep 2009 17:46:30 +0200	[thread overview]
Message-ID: <200909271746.30542.rjw@sisk.pl> (raw)
In-Reply-To: <2674af740909270701u6febabdbpc5c772fabc193b32@mail.gmail.com>

On Sunday 27 September 2009, Yong Zhang wrote:
> On Sun, Sep 27, 2009 at 6:25 PM, Maciej Rutecki
> <maciej.rutecki@gmail.com> wrote:
> > 2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
> >>
> >> Oops, TABLE is corrupted. Please use the attachment.
> >
> > kernel/time/timekeeping.c: In function ‘timekeeping_resume’:
> > kernel/time/timekeeping.c:577: error: ‘xtime_locks’ undeclared (first
> > use in this function)
> > kernel/time/timekeeping.c:577: error: (Each undeclared identifier is
> > reported only once
> > kernel/time/timekeeping.c:577: error: for each function it appears
> > in.)
> > make[3]: *** [kernel/time/timekeeping.o] Błąd 1
> > make[2]: *** [kernel/time] Błąd 2
> >
> >
> > I change:
> > write_seqlock(&xtime_locks);
> > to:
> > write_seqlock(&xtime_lock);
> >
> 
> Oh, typo error.
> 
> > Corrected patch in attachment.
> >
> > First warning has gone, but still I have this:
> > [  120.868049] SMP alternatives: switching to UP code
> > [  120.872570] CPU0 attaching NULL sched-domain.
> > [  120.872574] CPU1 attaching NULL sched-domain.
> > [  120.872581] CPU0 attaching NULL sched-domain.
> > [  120.872787] CPU1 is down
> > [  120.872846] Extended CMOS year: 2000
> > [  120.872945] PM: Creating hibernation image:
> > [  120.876009] PM: Need to copy 107120 pages
> > [  120.872009] PM: Restoring platform NVS memory
> > [  120.872009] CPU0: Thermal monitoring handled by SMI
> > [  120.872009] Extended CMOS year: 2000
> > [  120.872009] ------------[ cut here ]------------
> > [  120.872009] WARNING: at drivers/base/sys.c:353
> > __sysdev_resume+0xc3/0xe0()
> > [  120.872009] Hardware name: HP Compaq nx6310 (EY501ES#AKD)
> > [  120.872009] Interrupts enabled after timekeeping_resume+0x0/0x1c0
> 
> Irq is enabled after timekeeping_resume(), the previous patch do something
> sensible. But we even don't know when the irq is enabled. such as in
> timekeeping_resume() or before enter timekeeping_resume(). But it
> seem that this is not due to timekeeping_resume(). Instead I'm afraid
> it's caused by buggy driver.

Interrupts are disabled by the suspend core code right before sysdev_suspend(),
so device drivers cannot make this happen.  One of the sysdevs is doing this.

Thanks,
Rafael

  parent reply	other threads:[~2009-09-27 15:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27  8:05 [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0() Maciej Rutecki
2009-09-27  8:27 ` Yong Zhang
2009-09-27  8:30   ` Yong Zhang
2009-09-27 10:25     ` Maciej Rutecki
2009-09-27 14:01       ` Yong Zhang
2009-09-27 14:49         ` Yong Zhang
2009-09-27 14:49           ` Yong Zhang
2009-09-27 15:40           ` Rafael J. Wysocki
2009-09-27 16:16           ` Maciej Rutecki
2009-09-27 16:16             ` Maciej Rutecki
2009-09-27 18:17             ` Rafael J. Wysocki
2009-09-28  1:54             ` Yong Zhang
2009-09-28  1:54               ` Yong Zhang
2009-09-28 18:38               ` Maciej Rutecki
2009-09-28 18:38                 ` Maciej Rutecki
2009-09-28 20:08                 ` Maciej Rutecki
2009-09-28 20:08                   ` Maciej Rutecki
2009-09-28 21:13                   ` Rafael J. Wysocki
2009-09-29  5:44                 ` Yong Zhang
2009-09-29  5:44                   ` Yong Zhang
2009-09-27 15:46         ` Rafael J. Wysocki [this message]
2009-09-28  1:53           ` Yong Zhang
2009-09-29  7:24   ` Ingo Molnar
2009-09-29  9:31     ` Yong Zhang
2009-09-30  7:50       ` Michal Schmidt
2009-09-30  8:01         ` Yong Zhang
2009-09-30  8:20           ` Michal Schmidt
2009-09-30  8:27             ` Yong Zhang
2009-09-29 14:38     ` Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909271746.30542.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=clemens@ladisch.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.