All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: tglx@linutronix.de, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Ondrej Zary <linux@rainbow-software.org>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: T400 suspend/resume regression -- bisected to a mystery merge commit
Date: Mon, 28 Sep 2009 09:51:09 -0400	[thread overview]
Message-ID: <20090928135109.GB17514@mit.edu> (raw)
In-Reply-To: <200909271813.42829.rjw@sisk.pl>

On Sun, Sep 27, 2009 at 06:13:42PM +0200, Rafael J. Wysocki wrote:
> 
> commit c7121843685de2bf7f3afd3ae1d6a146010bf1fc
> Author: Magnus Damm <magnus.damm@gmail.com>
> Date:   Tue Jul 28 14:09:55 2009 -0700
> 
>     clocksource: Save mult_orig in clocksource_disable()
> 
> Please try to revert it and retest.

Using Linus's suggested technique, I bisected it down to this commit:

Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date:   Fri Aug 14 15:47:30 2009 +0200

    timekeeping: Update clocksource with stop_machine
    
    update_wall_time calls change_clocksource HZ times per second to check
    if a new clock source is available. In close to 100% of all calls
    there is no new clock. Replace the tick based check by an update done
    with stop_machine.
    
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Acked-by: John Stultz <johnstul@us.ibm.com>
    Cc: Daniel Walker <dwalker@fifo99.com>
    LKML-Reference: <20090814134810.711836357@de.ibm.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Unfortunately there are a bunch of patches I'm trying to get in shape
to push to Linus (the merge window coincided unfortunately with
LinuxCon/Plumbeer's so I'm a bit behind) so I haven't had a chance to
take it further.  I'll try reverting each of the above two patches,
and report back in a day or two.

    	   	   				- Ted

  reply	other threads:[~2009-09-28 13:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-26  6:57 T400 suspend/resume regression -- bisected to a mystery merge commit Theodore Ts'o
2009-09-26 16:28 ` Linus Torvalds
2009-09-27  8:08 ` Len Brown
2009-09-27 16:13 ` Rafael J. Wysocki
2009-09-28 13:51   ` Theodore Tso [this message]
2009-09-28 21:22     ` Rafael J. Wysocki
2009-10-02  0:59       ` Theodore Tso
2009-10-02  1:21         ` Linus Torvalds
2009-10-02  8:02           ` Martin Schwidefsky
2009-10-02 22:34           ` Theodore Tso
2009-10-02  6:50     ` Magnus Damm
2009-10-02 17:51       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928135109.GB17514@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=magnus.damm@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.