All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: Re: [PATCH 2/3] differentiate between S.I. and binary units in output
Date: Mon, 28 Sep 2009 10:37:54 -0400	[thread overview]
Message-ID: <20090928143753.GA26974@redhat.com> (raw)
In-Reply-To: <20090928142531.GF5351@agk-dp.fab.redhat.com>

On Mon, Sep 28 2009 at 10:25am -0400,
Alasdair G Kergon <agk@redhat.com> wrote:

> On Mon, Sep 28, 2009 at 09:17:59AM -0400, Mike Snitzer wrote:
> > I agree that 500-byte sectors aren't meaningful but I added support for
> > them a few months ago to be consistent, see:
> > http://sources.redhat.com/git/?p=lvm2.git;a=commit;h=69da2ac0
> 
> Where's that in WHATS_NEW?
> 
> I'll probably take it back out: I can't think of any reason for supporting it
> and confusing people.

Right, I agree that confusing people isn't good.. but I thought it
better to allow people to specify 'S' without erroring out.

As for WHATS_NEW; I added the following to the 2.02.49 release:
Update the man pages to document size units uniformly.
Allow commandline sizes to be specified in terms of bytes and sectors.

If you do back it out please still allow 's'; it is needed for pvcreate
--dataalignmentoffset 

But as we discussed, its probably best if both 's' and 'S' mean 512
bytes.

Mike



  reply	other threads:[~2009-09-28 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-26 15:33 [PATCH 1/3] use display_size function instead of hardcoding Daniel Mierswa
2009-09-26 15:33 ` [PATCH 2/3] differentiate between S.I. and binary units in output Daniel Mierswa
2009-09-28 12:49   ` Alasdair G Kergon
2009-09-28 13:17     ` Mike Snitzer
2009-09-28 14:25       ` Alasdair G Kergon
2009-09-28 14:37         ` Mike Snitzer [this message]
2009-09-28 16:44   ` Alasdair G Kergon
2009-09-30  1:00     ` Daniel Mierswa
2009-09-30 14:20       ` Alasdair G Kergon
2009-09-26 15:33 ` [PATCH 3/3] adjust the testsuite to work with new output Daniel Mierswa
2009-09-28 12:15 ` [PATCH 1/3] use display_size function instead of hardcoding Alasdair G Kergon
2009-09-28 16:31 ` Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928143753.GA26974@redhat.com \
    --to=snitzer@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.