All of lore.kernel.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Make MMCI driver compile without gpiolib
Date: Mon, 28 Sep 2009 21:18:52 +0200	[thread overview]
Message-ID: <20090928191852.GA20433@tarshish> (raw)
In-Reply-To: <63386a3d0909281200m1da30d22h4ea4fb72278941de@mail.gmail.com>

Hi Linus,

On Mon, Sep 28, 2009 at 09:00:01PM +0200, Linus Walleij wrote:
> Hm thinking back at this:
> 
> 2009/9/27 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> 
> > The real problem is that U300 doesn't implement gpio_is_valid() -
> > which is part of the GPIO API and not specific to GPIOLIB.
> 
> None of the GPIO drivers in drivers/gpio implement gpio_is_valid()
> though they all select GPIOLIB which in turn selects GENERIC_GPIO.
> 
> With one of them being the PL061 this means that the not so
> unlikely combination of PL061+PL180 will fail to compile (even
> though I'm not aware of such a platform for the time being).

Shouldn't gpio_is_valid() be implemented at the platform code? How should the 
generic GPIO driver know the number of valid GPIO lines, or the number of 
PL061 blocks for that matter?

> Is it worth taking a run over drivers/gpio and try to fix this or
> atleast the PL061 driver? I can have a look at it.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2009-09-28 19:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-26  8:56 [PATCH] Make MMCI driver compile without gpiolib Linus Walleij
2009-09-27 15:31 ` Russell King - ARM Linux
2009-09-27 19:11   ` Linus Walleij
2009-09-28 19:00   ` Linus Walleij
2009-09-28 19:18     ` Baruch Siach [this message]
2009-09-28 20:03     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090928191852.GA20433@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.