From: Florian Mickler <florian@mickler.org>
To: Andreas Schwab <schwab@linux-m68k.org>,
linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>
Subject: Re: [PATCH] tty: fix vt_compat_ioctl
Date: Tue, 29 Sep 2009 01:56:15 +0200 [thread overview]
Message-ID: <20090929015615.022f1ef2@schatten> (raw)
In-Reply-To: <m2tyymho45.fsf@igel.home>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Hi!
On Mon, 28 Sep 2009 21:21:14 +0200
Andreas Schwab <schwab@linux-m68k.org> wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote:
> >> Call compat_unimap_ioctl, not do_unimap_ioctl.
> >
> > That's a nice description of what the patch does, but why do we need to
> > do that?
>
> It's a compat ioctl handler, so lets call the compat ioctl handler.
>
> Andreas.
>
Any other reasons? Why not rename the call then? That would be a
functional no-op with the same effect...
Sincerely,
Florian
p.s. maybe it is obvious if one looks at the code (i didnt), but it
should be described nonetheless in the commit-log!
--
A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
>> A: Top-posting.
>>> Q: What is the most annoying thing in e-mail?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-09-29 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 18:10 [PATCH] tty: fix vt_compat_ioctl Andreas Schwab
2009-09-28 18:33 ` Greg KH
2009-09-28 19:21 ` Andreas Schwab
2009-09-28 23:56 ` Florian Mickler [this message]
2009-09-29 12:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929015615.022f1ef2@schatten \
--to=florian@mickler.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.