From: Stephen Hemminger <shemminger@vyatta.com>
To: Shreyas Bhatewara <sbhatewara@vmware.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Stephen Hemminger <shemminger@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Jeff Garzik <jgarzik@pobox.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Chris Wright <chrisw@sous-sol.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
virtualization <virtualization@lists.linux-foundation.org>,
pv-drivers <pv-drivers@vmware.com>
Subject: Re: [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3
Date: Wed, 30 Sep 2009 17:39:23 -0700 [thread overview]
Message-ID: <20090930173923.4520716a@s6510> (raw)
In-Reply-To: <alpine.LRH.2.00.0909301432410.8073@localhost.localdomain>
On Wed, 30 Sep 2009 14:34:57 -0700 (PDT)
Shreyas Bhatewara <sbhatewara@vmware.com> wrote:
Note: your patch was linewrapped again
> +
> +
> +static void
> +vmxnet3_declare_features(struct vmxnet3_adapter *adapter, bool dma64)
> +{
> + struct net_device *netdev = adapter->netdev;
> +
> + netdev->features = NETIF_F_SG |
> + NETIF_F_HW_CSUM |
> + NETIF_F_HW_VLAN_TX |
> + NETIF_F_HW_VLAN_RX |
> + NETIF_F_HW_VLAN_FILTER |
> + NETIF_F_TSO |
> + NETIF_F_TSO6;
> +
> + printk(KERN_INFO "features: sg csum vlan jf tso tsoIPv6");
> +
> + adapter->rxcsum = true;
> + adapter->jumbo_frame = true;
> +
> + if (!disable_lro) {
> + adapter->lro = true;
> + printk(" lro");
> + }
Why not use NETIF_F_LRO and ethtool to control LRO support?
next prev parent reply other threads:[~2009-10-01 0:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 21:34 [PATCH 2.6.32-rc1] net: VMware virtual Ethernet NIC driver: vmxnet3 Shreyas Bhatewara
2009-09-30 21:34 ` Shreyas Bhatewara
2009-10-01 0:39 ` Stephen Hemminger
2009-10-01 0:39 ` Stephen Hemminger [this message]
2009-10-01 1:18 ` Shreyas Bhatewara
2009-10-01 1:18 ` Shreyas Bhatewara
2009-10-01 2:51 ` David Miller
2009-10-01 2:51 ` David Miller
2009-10-01 22:23 ` David Miller
2009-10-01 22:23 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-09-30 21:34 Shreyas Bhatewara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930173923.4520716a@s6510 \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
--cc=shemminger@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.