From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: Simplify restart logic and fix races Date: Wed, 30 Sep 2009 22:39:38 -0500 Message-ID: <20091001033938.GA9718@us.ibm.com> References: <1254361634-30076-1-git-send-email-orenl@librato.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1254361634-30076-1-git-send-email-orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org): > This series simplifies adn tightens the restart logic and solves a > couple of races that annoyed Serge recently: > > * c/r: simplify logic of tracking restarting tasks > * c/r: let entire thread group in sys_restart before restoring a thread > * c/r: introduce walk_task_subtree() to iterate through descendants > * c/r: fix restart failure due to a race with ghost/dead tasks > * c/r: defer restore of blocked signals mask during restart > > Applies on ckpt-v18, works well on my tests. > > Oren. I want to review these in detail tomorrow, so I'll send acks then, but definately Tested-by: Serge Hallyn This passes all of the tests in git://git.sr71.net/~hallyn/cr_tests.git repeatedly. thanks, -serge