From: Christoph Hellwig <hch@infradead.org>
To: Juan Quintela <quintela@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, kvm@vger.kernel.org
Subject: Re: [PATCH 05/24] compatfd is included before, and it is compiled unconditionally
Date: Thu, 1 Oct 2009 08:05:08 -0400 [thread overview]
Message-ID: <20091001120508.GA2459@infradead.org> (raw)
In-Reply-To: <m3pr97fhrh.fsf@neno.mitica>
On Thu, Oct 01, 2009 at 01:58:10PM +0200, Juan Quintela wrote:
> Discused with Anthony about it. signalfd is complicated for qemu
> upstream (too difficult to use properly), and eventfd ... The current
> eventfd emulation is worse than the pipe code that it substitutes.
>
> His suggestion here was to create a new abstraction with an API like:
>
> push_notify()
>
> pop_notify()
>
> and then you can implement it with eventfd() pipes/whatever.
>
> What was missing for you of compatfd: qemu_eventfd/qemu_signalfd?
> Do a push_notify()/pop_notify() work for you?
I don't desperately want to use it myself anyway. I just want to get
rid of the highly annoyind spurious differences in the AIO code due
to use of compatfd. I would be perfectly fine with just killing this
use of eventfd in qemu-kvm.
next prev parent reply other threads:[~2009-10-01 12:05 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 11:41 [PATCH 00/24] configure and Makefile cleanup Juan Quintela
2009-09-18 11:41 ` [PATCH 01/24] Don't disable werror unconditionally Juan Quintela
2009-09-18 19:02 ` Marcelo Tosatti
2009-09-19 10:13 ` Avi Kivity
2009-09-19 11:14 ` Jan Kiszka
2009-09-19 11:41 ` Juan Quintela
2009-09-18 11:41 ` [PATCH 02/24] extboot.bin is a generated file Juan Quintela
2009-09-18 11:41 ` [PATCH 03/24] Remove merge artifacts Juan Quintela
2009-09-18 11:41 ` [PATCH 04/24] piix4_dev is not used for pc's Juan Quintela
2009-09-18 19:05 ` Marcelo Tosatti
2009-09-18 21:42 ` Juan Quintela
2009-09-21 9:10 ` Avi Kivity
2009-09-21 9:37 ` Juan Quintela
2009-09-21 9:45 ` Avi Kivity
2009-09-18 11:41 ` [PATCH 05/24] compatfd is included before, and it is compiled unconditionally Juan Quintela
2009-09-22 13:19 ` Christoph Hellwig
2009-09-22 13:25 ` Juan Quintela
2009-09-22 13:34 ` Christoph Hellwig
2009-10-01 11:58 ` Juan Quintela
2009-10-01 12:05 ` Christoph Hellwig [this message]
2009-10-01 14:24 ` Anthony Liguori
2009-10-01 14:23 ` Anthony Liguori
2009-10-01 14:44 ` Avi Kivity
2009-10-01 16:50 ` Anthony Liguori
2009-10-01 17:00 ` Avi Kivity
2009-10-05 20:48 ` KVM Support for windows Saksena, Abhishek
2009-10-06 10:51 ` Avi Kivity
2009-09-18 11:41 ` [PATCH 06/24] Use common style for signalfd Juan Quintela
2009-09-18 11:41 ` [PATCH 07/24] One CONFIG_EVENTFD should be enough Juan Quintela
2009-09-18 11:41 ` [PATCH 08/24] Bring ia64 to current arch selection code Juan Quintela
2009-09-18 11:41 ` [PATCH 09/24] Use configure way of enabling kvm Juan Quintela
2009-09-18 11:41 ` [PATCH 10/24] Prin kvm options values as everything else Juan Quintela
2009-09-18 11:41 ` [PATCH 11/24] KVM temp hack not needed anymore Juan Quintela
2009-09-18 11:41 ` [PATCH 12/24] Introduce libs_softmmu to device assignment code Juan Quintela
2009-09-18 11:41 ` [PATCH 13/24] Use compile_prog function in thee missing compilations Juan Quintela
2009-09-18 11:41 ` [PATCH 14/24] Test for libpci, not only for header Juan Quintela
2009-09-18 11:41 ` [PATCH 15/24] Rename USE_KVM_* to CONFIG_KVM_* Juan Quintela
2009-09-18 11:41 ` [PATCH 16/24] Move kvm specific tests after main kvm test Juan Quintela
2009-09-18 11:41 ` [PATCH 17/24] Add kvm-cap-pit command line flags Juan Quintela
2009-09-18 11:41 ` [PATCH 18/24] Add kvm-cap-device-assignment " Juan Quintela
2009-09-18 11:41 ` [PATCH 19/24] Fix compilation without device assignment Juan Quintela
2009-09-18 11:41 ` [PATCH 20/24] Only print kvm options when kvm is enabled Juan Quintela
2009-09-18 19:42 ` Marcelo Tosatti
2009-09-18 21:43 ` Juan Quintela
2009-09-18 11:41 ` [PATCH 21/24] __user is not used anywhere in qemu sources Juan Quintela
2009-09-18 11:41 ` [PATCH 22/24] fix mis-merge (we define pkgversion 3 lines above Juan Quintela
2009-09-18 11:41 ` [PATCH 23/24] Get CONFIG_CPU_EMULATION back to life Juan Quintela
2009-09-18 19:54 ` Marcelo Tosatti
2009-09-18 21:44 ` Juan Quintela
2009-09-21 9:13 ` Avi Kivity
2009-09-21 9:36 ` Juan Quintela
2009-09-18 11:41 ` [PATCH 24/24] Remove build-targets-* rules that are always empty Juan Quintela
2009-09-18 19:57 ` [PATCH 00/24] configure and Makefile cleanup Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001120508.GA2459@infradead.org \
--to=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.