From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: Use codec mutex in dapm_set_pga()
Date: Thu, 1 Oct 2009 13:09:31 +0100 [thread overview]
Message-ID: <20091001120931.GF19998@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1254398184.2472.45.camel@eenurkka-desktop>
On Thu, Oct 01, 2009 at 02:56:24PM +0300, Eero Nurkkala wrote:
> Actually, in this case: (kernel 2.6.28)
That's rather old...
> But if it didn't come from snd_soc_dapm_put_volsw(),
> but instead:
> close_delayed_work() ->
> snd_soc_dapm_stream_event() ->
> dapm_power_widgets() ->
> dapm_set_pga()
> then the codec->mutex is not taken,
> and the bug presented in the patch is out there, no?
Right, so close_delayed_work() needs to lock the card while it runs.
next prev parent reply other threads:[~2009-10-01 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 6:17 [PATCH] ASoC: Use codec mutex in dapm_set_pga() ext-eero.nurkkala
2009-10-01 10:37 ` Mark Brown
2009-10-01 11:01 ` Eero Nurkkala
2009-10-01 11:56 ` Eero Nurkkala
2009-10-01 12:09 ` Mark Brown [this message]
2009-10-01 12:34 ` Eero Nurkkala
2009-10-01 12:45 ` Mark Brown
2009-10-01 12:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091001120931.GF19998@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ext-eero.nurkkala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.