From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ascenario: Add scenario support to alsa-lib Date: Thu, 1 Oct 2009 14:24:18 +0100 Message-ID: <20091001132417.GA26663@rakim.wolfsonmicro.main> References: <1254390436-5283-1-git-send-email-stefan@datenfreihafen.org> <1254390436-5283-2-git-send-email-stefan@datenfreihafen.org> <20091001122835.GC14417@sirena.org.uk> <20091001131948.GA5936@excalibur.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 25489103929 for ; Thu, 1 Oct 2009 15:24:19 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20091001131948.GA5936@excalibur.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Stefan Schmidt Cc: Ian Molton , alsa-devel@alsa-project.org, Graeme Gregory , Stefan Schmidt , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Oct 01, 2009 at 03:19:48PM +0200, Stefan Schmidt wrote: > On Thu, 2009-10-01 at 13:28, Mark Brown wrote: > > > +/** Scenario ID's > > > + * > > > + * Standard Scenario ID's - Add new scenarios at the end. > > > + */ > > Extra 's here. > That way? > /** > * Scenario ID's > * > * Standard Scenario ID's - Add new scenarios at the end. > */ There shouldn't be any 's in the above at all ("Scenarios IDs" instead), those are just plain plurals - just a trivial grammar nit. > > I guess the idea is that in the future this will be removed and the > > scenario API will use inotify or similar to pick up changes. > Indeed. Certainly a Todo item for later enhancements. Do you guys prefer such > todo items in the code or noted somewhere else? I have no great preference either way.