From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <petkovbb@googlemail.com>,
Andi Kleen <andi@firstfloor.org>,
x86@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] EDAC: carve out AMD MCE decoding logic
Date: Fri, 2 Oct 2009 20:26:59 +0200 [thread overview]
Message-ID: <20091002182659.GA16436@aftab> (raw)
In-Reply-To: <20091002133954.GA29390@elte.hu>
On Fri, Oct 02, 2009 at 03:39:54PM +0200, Ingo Molnar wrote:
> I suspect this is fine currently because no two EDAC modules should be
> active at the same time. A followup cleanup patch would be nice
> nevertheless that uses a notifier chain here with proper
> register/unregister locking.
Please do elaborate for I can't seem to follow.
AFAICT, we are going to have max one MCE decoder at any one time so no
need to notify it.
The x86_mce_decode_callback assignment probably needs locking just to be
on the safe side. We can do a
mce_set_decode_callback(void (*f)(struct mce*m))
helper which falls back to default_decode_mce() whenever its being
passed a NULL for *f using proper locking...
I'm pretty sure I'm missing something though...
--
Regards/Gruss,
Boris.
Operating | Advanced Micro Devices GmbH
System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
next prev parent reply other threads:[~2009-10-02 18:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 14:09 x86: mce: Please revert 22223c9b417be5fd0ab2cf9ad17eb7bd1e19f7b9 Andi Kleen
2009-09-30 19:40 ` Borislav Petkov
2009-09-30 20:46 ` Ingo Molnar
2009-09-30 21:48 ` Ingo Molnar
2009-09-30 22:39 ` Borislav Petkov
2009-09-30 23:09 ` Ingo Molnar
2009-10-01 14:14 ` Borislav Petkov
2009-10-01 14:34 ` Linus Torvalds
2009-10-01 14:46 ` Borislav Petkov
2009-10-01 15:00 ` Ingo Molnar
2009-10-01 15:21 ` Borislav Petkov
2009-10-01 15:32 ` Ingo Molnar
2009-10-02 13:21 ` Borislav Petkov
2009-10-02 13:22 ` [PATCH 1/3] x86, mce, edac: Fix MCE decoding callback logic Borislav Petkov
2009-10-02 13:23 ` [PATCH 2/3] initcalls: add early_initcall for modules Borislav Petkov
2009-10-02 14:01 ` [tip:x86/urgent] initcalls: Add early_initcall() " tip-bot for Borislav Petkov
2009-10-02 13:26 ` x86: mce: Please revert 22223c9b417be5fd0ab2cf9ad17eb7bd1e19f7b9 Ingo Molnar
2009-10-02 13:31 ` [PATCH 3/3] EDAC: carve out AMD MCE decoding logic Borislav Petkov
2009-10-02 13:39 ` Ingo Molnar
2009-10-02 18:26 ` Borislav Petkov [this message]
2009-10-02 18:47 ` Ingo Molnar
2009-10-03 6:57 ` Borislav Petkov
2009-10-03 7:18 ` Ingo Molnar
2009-10-05 15:15 ` Borislav Petkov
2009-10-16 12:55 ` [tip:perf/mce] mce, edac: Use an atomic notifier for MCEs decoding tip-bot for Borislav Petkov
2009-10-02 14:01 ` [tip:x86/urgent] x86: EDAC: carve out AMD MCE decoding logic tip-bot for Borislav Petkov
2009-10-01 14:55 ` x86: mce: Please revert 22223c9b417be5fd0ab2cf9ad17eb7bd1e19f7b9 Ingo Molnar
2009-10-01 15:26 ` Andi Kleen
2009-10-02 14:01 ` [tip:x86/urgent] x86: EDAC: MCE: Fix MCE decoding callback logic tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091002182659.GA16436@aftab \
--to=borislav.petkov@amd.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=petkovbb@googlemail.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.